You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/10/08 20:25:47 UTC
Review Request 39135: Fixed teardown test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39135/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
This teardown endpoint test needs valid credentials to really test a missing 'frameworkID' request.
Note: this change is also needed as dependant patch fixes how we validate credentials in master endpoints.
Diffs
-----
src/tests/teardown_tests.cpp 2eeead7
Diff: https://reviews.apache.org/r/39135/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez
Re: Review Request 39135: Fixed teardown test
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39135/#review102267
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Oct. 8, 2015, 6:25 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39135/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 6:25 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This teardown endpoint test needs valid credentials to really test a missing 'frameworkID' request.
> Note: this change is also needed as dependant patch fixes how we validate credentials in master endpoints.
>
>
> Diffs
> -----
>
> src/tests/teardown_tests.cpp 2eeead7
>
> Diff: https://reviews.apache.org/r/39135/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39135: Fixed teardown test
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39135/#review102229
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十月 8, 2015, 6:25 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39135/
> -----------------------------------------------------------
>
> (Updated 十月 8, 2015, 6:25 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This teardown endpoint test needs valid credentials to really test a missing 'frameworkID' request.
> Note: this change is also needed as dependant patch fixes how we validate credentials in master endpoints.
>
>
> Diffs
> -----
>
> src/tests/teardown_tests.cpp 2eeead7
>
> Diff: https://reviews.apache.org/r/39135/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>