[GitHub] [avro] zcsizmadia edited a comment on pull request #1531: AVRO-3259: Throw exception if unknown codec

[GitBox <gi...@apache.org>]

zcsizmadia edited a comment on pull request #1531:
URL: https://github.com/apache/avro/pull/1531#issuecomment-1034343395


   It is important to call out that avro.codec meta data is not defined, the codec is assumed to be "null". I guess that was the reason behind defaulting the codec to null in that case statement, which caused the issue in the ticket
   
   The only concern I have here is really the lack of avro.code metadata in the avro file, however it should be ok.  Maybe we should have a unit test which creates an avro file without the avro.codec metdata (if it is possible at all), and check the code selects the null codec.
   
   https://avro.apache.org/docs/current/spec.html (search for avro.codec)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org