You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Deepak Barr <de...@gmail.com> on 2016/08/17 10:44:53 UTC
Review Request 51175: LENS-1277 : Make threadpool sizes configurable
for grizzly lens server
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51175/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1277
https://issues.apache.org/jira/browse/LENS-1277
Repository: lens
Description
-------
Unlike other servers, Reconfiguring grizzly threadpool requires a java code change.
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 57d13f9
lens-server/src/main/java/org/apache/lens/server/LensServer.java 203c249
lens-server/src/main/resources/lensserver-default.xml 460e3dd
Diff: https://reviews.apache.org/r/51175/diff/
Testing
-------
Yes.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.606 s]
[INFO] Lens ............................................... SUCCESS [ 2.867 s]
[INFO] Lens API ........................................... SUCCESS [ 17.072 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 15.527 s]
[INFO] Lens Cube .......................................... SUCCESS [13:04 min]
[INFO] Lens DB storage .................................... SUCCESS [ 11.913 s]
[INFO] Lens Query Library ................................. SUCCESS [ 9.820 s]
[INFO] Lens Hive Driver ................................... SUCCESS [21:45 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 25.224 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 13.784 s]
[INFO] Lens Server ........................................ SUCCESS [13:16 min]
[INFO] Lens client ........................................ SUCCESS [01:19 min]
[INFO] Lens CLI ........................................... SUCCESS [01:02 min]
[INFO] Lens Examples ...................................... SUCCESS [ 5.496 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.523 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.798 s]
[INFO] Lens ML Lib ........................................ SUCCESS [ 56.807 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.532 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.783 s]
[INFO] Lens UI ............................................ SUCCESS [ 3.418 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 53:35 min
[INFO] Finished at: 2016-08-17T14:02:19+05:30
[INFO] Final Memory: 181M/1690M
[INFO] ------------------------------------------------------------------------
Thanks,
Deepak Barr
Re: Review Request 51175: LENS-1277 : Make threadpool sizes
configurable for grizzly lens server
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51175/#review145983
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/LensServer.java (line 102)
<https://reviews.apache.org/r/51175/#comment212330>
ThreadpoolConfig which comes with default implementation is handling *uncaughtexceptions*. Can we add **threadFactory to threadPoolConfig** here as well?
Refer the following link
https://github.com/jersey/jersey/blob/master/containers/grizzly2-http/src/main/java/org/glassfish/jersey/grizzly2/httpserver/GrizzlyHttpServerFactory.java#L268
lens-server/src/main/resources/lensserver-default.xml (line 898)
<https://reviews.apache.org/r/51175/#comment212331>
Regenerate docs with these properties?
- Raju Bairishetti
On Aug. 17, 2016, 10:44 a.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51175/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2016, 10:44 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1277
> https://issues.apache.org/jira/browse/LENS-1277
>
>
> Repository: lens
>
>
> Description
> -------
>
> Unlike other servers, Reconfiguring grizzly threadpool requires a java code change.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 57d13f9
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 203c249
> lens-server/src/main/resources/lensserver-default.xml 460e3dd
>
> Diff: https://reviews.apache.org/r/51175/diff/
>
>
> Testing
> -------
>
> Yes.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.606 s]
> [INFO] Lens ............................................... SUCCESS [ 2.867 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.072 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 15.527 s]
> [INFO] Lens Cube .......................................... SUCCESS [13:04 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 11.913 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 9.820 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [21:45 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 25.224 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 13.784 s]
> [INFO] Lens Server ........................................ SUCCESS [13:16 min]
> [INFO] Lens client ........................................ SUCCESS [01:19 min]
> [INFO] Lens CLI ........................................... SUCCESS [01:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 5.496 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.523 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.798 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [ 56.807 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.532 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.783 s]
> [INFO] Lens UI ............................................ SUCCESS [ 3.418 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 53:35 min
> [INFO] Finished at: 2016-08-17T14:02:19+05:30
> [INFO] Final Memory: 181M/1690M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 51175: LENS-1277 : Make threadpool sizes
configurable for grizzly lens server
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51175/#review146339
-----------------------------------------------------------
Ship it!
Ship It!
- Raju Bairishetti
On Aug. 22, 2016, 11:57 a.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51175/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2016, 11:57 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1277
> https://issues.apache.org/jira/browse/LENS-1277
>
>
> Repository: lens
>
>
> Description
> -------
>
> Unlike other servers, Reconfiguring grizzly threadpool requires a java code change.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 57d13f9
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 203c249
> lens-server/src/main/resources/lensserver-default.xml 460e3dd
> src/site/apt/admin/config.apt 6651ec2
>
> Diff: https://reviews.apache.org/r/51175/diff/
>
>
> Testing
> -------
>
> Yes.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.583 s]
> [INFO] Lens ............................................... SUCCESS [ 2.867 s]
> [INFO] Lens API ........................................... SUCCESS [ 14.827 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 14.173 s]
> [INFO] Lens Cube .......................................... SUCCESS [09:56 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 11.168 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 9.765 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [01:13 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 24.890 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.514 s]
> [INFO] Lens Server ........................................ SUCCESS [13:23 min]
> [INFO] Lens client ........................................ SUCCESS [01:21 min]
> [INFO] Lens CLI ........................................... SUCCESS [01:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 5.775 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.526 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.964 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [ 59.476 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.831 s]
> [INFO] Lens Regression .................................... SUCCESS [ 9.055 s]
> [INFO] Lens UI ............................................ SUCCESS [ 3.813 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:05 min
> [INFO] Finished at: 2016-08-22T16:44:55+05:30
> [INFO] Final Memory: 178M/1672M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 51175: LENS-1277 : Make threadpool sizes
configurable for grizzly lens server
Posted by Deepak Barr <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51175/
-----------------------------------------------------------
(Updated Aug. 22, 2016, 11:57 a.m.)
Review request for lens.
Bugs: LENS-1277
https://issues.apache.org/jira/browse/LENS-1277
Repository: lens
Description
-------
Unlike other servers, Reconfiguring grizzly threadpool requires a java code change.
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 57d13f9
lens-server/src/main/java/org/apache/lens/server/LensServer.java 203c249
lens-server/src/main/resources/lensserver-default.xml 460e3dd
src/site/apt/admin/config.apt 6651ec2
Diff: https://reviews.apache.org/r/51175/diff/
Testing (updated)
-------
Yes.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.583 s]
[INFO] Lens ............................................... SUCCESS [ 2.867 s]
[INFO] Lens API ........................................... SUCCESS [ 14.827 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 14.173 s]
[INFO] Lens Cube .......................................... SUCCESS [09:56 min]
[INFO] Lens DB storage .................................... SUCCESS [ 11.168 s]
[INFO] Lens Query Library ................................. SUCCESS [ 9.765 s]
[INFO] Lens Hive Driver ................................... SUCCESS [01:13 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 24.890 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.514 s]
[INFO] Lens Server ........................................ SUCCESS [13:23 min]
[INFO] Lens client ........................................ SUCCESS [01:21 min]
[INFO] Lens CLI ........................................... SUCCESS [01:04 min]
[INFO] Lens Examples ...................................... SUCCESS [ 5.775 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.526 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.964 s]
[INFO] Lens ML Lib ........................................ SUCCESS [ 59.476 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.831 s]
[INFO] Lens Regression .................................... SUCCESS [ 9.055 s]
[INFO] Lens UI ............................................ SUCCESS [ 3.813 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:05 min
[INFO] Finished at: 2016-08-22T16:44:55+05:30
[INFO] Final Memory: 178M/1672M
[INFO] ------------------------------------------------------------------------
Thanks,
Deepak Barr
Re: Review Request 51175: LENS-1277 : Make threadpool sizes
configurable for grizzly lens server
Posted by Deepak Barr <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51175/
-----------------------------------------------------------
(Updated Aug. 22, 2016, 11:56 a.m.)
Review request for lens.
Changes
-------
Addressed review comments.
Bugs: LENS-1277
https://issues.apache.org/jira/browse/LENS-1277
Repository: lens
Description
-------
Unlike other servers, Reconfiguring grizzly threadpool requires a java code change.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 57d13f9
lens-server/src/main/java/org/apache/lens/server/LensServer.java 203c249
lens-server/src/main/resources/lensserver-default.xml 460e3dd
src/site/apt/admin/config.apt 6651ec2
Diff: https://reviews.apache.org/r/51175/diff/
Testing
-------
Yes.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.606 s]
[INFO] Lens ............................................... SUCCESS [ 2.867 s]
[INFO] Lens API ........................................... SUCCESS [ 17.072 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 15.527 s]
[INFO] Lens Cube .......................................... SUCCESS [13:04 min]
[INFO] Lens DB storage .................................... SUCCESS [ 11.913 s]
[INFO] Lens Query Library ................................. SUCCESS [ 9.820 s]
[INFO] Lens Hive Driver ................................... SUCCESS [21:45 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 25.224 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 13.784 s]
[INFO] Lens Server ........................................ SUCCESS [13:16 min]
[INFO] Lens client ........................................ SUCCESS [01:19 min]
[INFO] Lens CLI ........................................... SUCCESS [01:02 min]
[INFO] Lens Examples ...................................... SUCCESS [ 5.496 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.523 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.798 s]
[INFO] Lens ML Lib ........................................ SUCCESS [ 56.807 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.532 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.783 s]
[INFO] Lens UI ............................................ SUCCESS [ 3.418 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 53:35 min
[INFO] Finished at: 2016-08-17T14:02:19+05:30
[INFO] Final Memory: 181M/1690M
[INFO] ------------------------------------------------------------------------
Thanks,
Deepak Barr