You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 06:30:50 UTC
[PR] [ISSUE #10768] Continue queryRoute after missing broker data [rocketmq]
Aias00 opened a new pull request, #10769:
URL: https://github.com/apache/rocketmq/pull/10769
### What changed
This PR makes Proxy gRPC `RouteActivity#queryRoute` skip only the malformed queue row when its broker name is absent from the built broker map.
Previously the loop used `break`, so one stale/malformed `QueueData` entry could stop processing later valid queue rows and truncate the route response.
### Why
A missing broker mapping should not hide valid queue routes that appear later in the same route data. This can affect gRPC route discovery when route metadata contains stale queue data.
Fixes #10768.
### Verification
```bash
mvn -pl proxy -Dtest=RouteActivityTest test
```
Result: BUILD SUCCESS. `RouteActivityTest` ran 8 tests with 0 failures/errors/skips. Checkstyle and SpotBugs also passed in the Maven run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #10768] Continue queryRoute after missing broker data [rocketmq]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #10769: [ISSUE #10768] Continue queryRoute after missing broker data
URL: https://github.com/apache/rocketmq/pull/10769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #10768] Continue queryRoute after missing broker data [rocketmq]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #10769:
URL: https://github.com/apache/rocketmq/pull/10769#issuecomment-5301204005
Consolidated into #10771; both changes harden RouteActivity behavior for incomplete Broker data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #10768] Continue queryRoute after missing broker data [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10769:
URL: https://github.com/apache/rocketmq/pull/10769#issuecomment-5163271050
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10769?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.26%. Comparing base ([`eddb235`](https://app.codecov.io/gh/apache/rocketmq/commit/eddb235c1bd8adc5c3a1125a294405526e7bb0e3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e883802`](https://app.codecov.io/gh/apache/rocketmq/commit/e883802ba57ac683e24fa76fbb505e696d014f80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #10769 +/- ##
=============================================
+ Coverage 48.24% 48.26% +0.02%
- Complexity 13496 13497 +1
=============================================
Files 1380 1380
Lines 101104 101104
Branches 13107 13107
=============================================
+ Hits 48773 48794 +21
+ Misses 46350 46334 -16
+ Partials 5981 5976 -5
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/10769?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org