[GitHub] [pulsar] merlimat commented on issue #3741: POJO AvroSchema always allowNull

[GitBox <gi...@apache.org>]

merlimat commented on issue #3741: POJO AvroSchema always allowNull
URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469447865
 
 
   Irrespective of the `allowNull=true/false` question, I think: 
    1. This seems to be a problem only with Avro generated code, in which there was a schema defined and we're extracting the wrong schema from the generated POJO
    2. This shouldn't be an issue when one defines an ad-hoc POJO (without starting from Avro schema), because annotations can be used to request nullable/non-nullable.
   
   The easiest solution would be to detect that a POJO is generated by Avro and use the `getClassSchema()` instead of doing the reflection based approach.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services