You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Stas Bekman <st...@stason.org> on 2006/01/21 01:13:10 UTC
issues with figuring out which mp version is running
The docs advertise invalid information about figuring out whether we are
running under mp2 or mp1:
use mod_perl;
use constant MP2 => ($mod_perl::VERSION >= 1.99);
that will always fail, since mp2 now lives in mod_perl2.pm.
I didn't check everywhere, but at least these docs need to be corrected:
http://perl.apache.org/docs/2.0/user/porting/compat.html#C__ENV_GATEWAY_INTERFACE__
http://perl.apache.org/docs/2.0/user/porting/porting.html#Making_Code_Conditional_on_Running_mod_perl_Version
I'm trying to make Apache::DProf to work under mp2 and I thought the
following will work:
die "mod_perl is required to run this module"
unless $ENV{MOD_PERL};
use constant MP2 => $ENV{MOD_PERL} >= 2;
but no such luck, since $ENV{MOD_PERL} is set at the end of post_config,
and Apache::DProf loads during the config phase.
I think setting of $ENV{MOD_PERL} needs to be moved to happen as soon as
perl starts and before we try to run any code or load any modules.
Thanks.
--
_____________________________________________________________
Stas Bekman mailto:stas@stason.org http://stason.org/
MailChannels: Assured Messaging(TM) http://mailchannels.com/
The "Practical mod_perl" book http://modperlbook.org/
http://perl.apache.org/ http://perl.org/ http://logilune.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Stas Bekman <st...@stason.org>.
Frank Wiles wrote:
> On Mon, 23 Jan 2006 16:05:57 -0600
> Frank Wiles <fr...@wiles.org> wrote:
>
>
>> I'll also update the docs to reflect this as there are a couple
>> of places this needs to change.
>
>
> Here is a patch to update the docs to get rid of the use of
> $mod_perl::VERSION in the 2.0 docs. I've basically replaced
> any use of:
>
> use constant MP2 => ($mod_perl::VERSION >= 1.99);
>
> or the similar constructs with:
>
> use constant MP2 => ( exists $ENV{MOD_PERL_API_VERSION} and
> $ENV{MOD_PERL_API_VERSION} >= 2 );
>
> I also removed a paragraph about how you need to make sure your
> module's $VERSION appears before using $mod_perl::VERSION in the code
> otherwise CPAN freaks out. I removed it because it no longer made
> sense to have it there, since it wasn't talking about
> $mod_perl::VERSION any longer.
Thanks Frank, committed.
--
_____________________________________________________________
Stas Bekman mailto:stas@stason.org http://stason.org/
MailChannels: Assured Messaging(TM) http://mailchannels.com/
The "Practical mod_perl" book http://modperlbook.org/
http://perl.apache.org/ http://perl.org/ http://logilune.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Stas Bekman <st...@stason.org>.
Frank Wiles wrote:
> On Mon, 23 Jan 2006 16:05:57 -0600
> Frank Wiles <fr...@wiles.org> wrote:
>
>
>> I'll also update the docs to reflect this as there are a couple
>> of places this needs to change.
>
>
> Here is a patch to update the docs to get rid of the use of
> $mod_perl::VERSION in the 2.0 docs. I've basically replaced
> any use of:
>
> use constant MP2 => ($mod_perl::VERSION >= 1.99);
>
> or the similar constructs with:
>
> use constant MP2 => ( exists $ENV{MOD_PERL_API_VERSION} and
> $ENV{MOD_PERL_API_VERSION} >= 2 );
>
> I also removed a paragraph about how you need to make sure your
> module's $VERSION appears before using $mod_perl::VERSION in the code
> otherwise CPAN freaks out. I removed it because it no longer made
> sense to have it there, since it wasn't talking about
> $mod_perl::VERSION any longer.
Thanks Frank, committed.
--
_____________________________________________________________
Stas Bekman mailto:stas@stason.org http://stason.org/
MailChannels: Assured Messaging(TM) http://mailchannels.com/
The "Practical mod_perl" book http://modperlbook.org/
http://perl.apache.org/ http://perl.org/ http://logilune.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Frank Wiles <fr...@wiles.org>.
On Mon, 23 Jan 2006 16:05:57 -0600
Frank Wiles <fr...@wiles.org> wrote:
> I'll also update the docs to reflect this as there are a couple
> of places this needs to change.
Here is a patch to update the docs to get rid of the use of
$mod_perl::VERSION in the 2.0 docs. I've basically replaced
any use of:
use constant MP2 => ($mod_perl::VERSION >= 1.99);
or the similar constructs with:
use constant MP2 => ( exists $ENV{MOD_PERL_API_VERSION} and
$ENV{MOD_PERL_API_VERSION} >= 2 );
I also removed a paragraph about how you need to make sure your
module's $VERSION appears before using $mod_perl::VERSION in the code
otherwise CPAN freaks out. I removed it because it no longer made
sense to have it there, since it wasn't talking about
$mod_perl::VERSION any longer.
Let me know if you want me to change anything.
---------------------------------
Frank Wiles <fr...@wiles.org>
http://www.wiles.org
---------------------------------
Re: issues with figuring out which mp version is running
Posted by Frank Wiles <fr...@wiles.org>.
On Mon, 23 Jan 2006 16:05:57 -0600
Frank Wiles <fr...@wiles.org> wrote:
> I'll also update the docs to reflect this as there are a couple
> of places this needs to change.
Here is a patch to update the docs to get rid of the use of
$mod_perl::VERSION in the 2.0 docs. I've basically replaced
any use of:
use constant MP2 => ($mod_perl::VERSION >= 1.99);
or the similar constructs with:
use constant MP2 => ( exists $ENV{MOD_PERL_API_VERSION} and
$ENV{MOD_PERL_API_VERSION} >= 2 );
I also removed a paragraph about how you need to make sure your
module's $VERSION appears before using $mod_perl::VERSION in the code
otherwise CPAN freaks out. I removed it because it no longer made
sense to have it there, since it wasn't talking about
$mod_perl::VERSION any longer.
Let me know if you want me to change anything.
---------------------------------
Frank Wiles <fr...@wiles.org>
http://www.wiles.org
---------------------------------
Re: issues with figuring out which mp version is running
Posted by Frank Wiles <fr...@wiles.org>.
On Mon, 23 Jan 2006 15:40:32 -0500
Geoffrey Young <ge...@modperlcookbook.org> wrote:
> >> if exists $ENV{MOD_PERL_API_VERSION} and ...
> >
> >
> > But these aren't populated if you use SetHandler modperl correct?
>
> no. these particular %ENV values are always populated, as they're
> mod_perl specific. the modperl handler just toggles cgi vars and
> other things coming from $r->subprocess_env.
Great I'll switch these in my modules and suggest it around to
others that I know are using this same technique.
I'll also update the docs to reflect this as there are a couple
of places this needs to change.
Thanks for the help!
---------------------------------
Frank Wiles <fr...@wiles.org>
http://www.wiles.org
---------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Frank Wiles wrote:
> On Mon, 23 Jan 2006 11:01:07 -0800
> Stas Bekman <st...@stason.org> wrote:
>
>
>>Stas Bekman wrote:
>>[...]
>>
>>>In which case checking $ENV{MOD_PERL_API_VERSION} should do the
>>>trick.
>>
>>Just remember that mod_perl1 doesn't have this env var. So it should
>>probably go like:
>>
>> if exists $ENV{MOD_PERL_API_VERSION} and ...
>
>
> But these aren't populated if you use SetHandler modperl correct?
no. these particular %ENV values are always populated, as they're mod_perl
specific. the modperl handler just toggles cgi vars and other things coming
from $r->subprocess_env.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Frank Wiles <fr...@wiles.org>.
On Mon, 23 Jan 2006 11:01:07 -0800
Stas Bekman <st...@stason.org> wrote:
> Stas Bekman wrote:
> [...]
> > In which case checking $ENV{MOD_PERL_API_VERSION} should do the
> > trick.
>
> Just remember that mod_perl1 doesn't have this env var. So it should
> probably go like:
>
> if exists $ENV{MOD_PERL_API_VERSION} and ...
But these aren't populated if you use SetHandler modperl correct?
Is that a problem for anyone?
---------------------------------
Frank Wiles <fr...@wiles.org>
http://www.wiles.org
---------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Stas Bekman wrote:
> Stas Bekman wrote:
> [...]
>
>> In which case checking $ENV{MOD_PERL_API_VERSION} should do the trick.
>
>
> Just remember that mod_perl1 doesn't have this env var. So it should
> probably go like:
>
> if exists $ENV{MOD_PERL_API_VERSION} and ...
yeah, we ran into that with CGI.pm...
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Stas Bekman <st...@stason.org>.
Stas Bekman wrote:
[...]
> In which case checking $ENV{MOD_PERL_API_VERSION} should do the trick.
Just remember that mod_perl1 doesn't have this env var. So it should
probably go like:
if exists $ENV{MOD_PERL_API_VERSION} and ...
--
_____________________________________________________________
Stas Bekman mailto:stas@stason.org http://stason.org/
MailChannels: Assured Messaging(TM) http://mailchannels.com/
The "Practical mod_perl" book http://modperlbook.org/
http://perl.apache.org/ http://perl.org/ http://logilune.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>
> Stas Bekman wrote:
>
>>Geoffrey Young wrote:
>>[...]
>>
>>
>>>but regardless, stas has a point - we need a definitive way to tell
>>>whether
>>>you are running under mp1 or mp2, then update the docs.
>>>
>>>my suggestion is to check for $ENV{MOD_PERL_API_VERSION}, which only
>>>exists
>>>in the official 2.0 API (mp 1.999_22 and later). if that isn't set at
>>>the
>>>earliest possible moment, before _any_ mod_perl hooks can be called,
>>>then we
>>>need to fix that.
>>
>>
>>That's the case. It needs to be fixed. And so do the docs.
>
>
> hmm...
>
> I started to work on this but couldn't get it to fail as you describe.
> basically all I did was add code that looked for $ENV{MOD_PERL_API_VERSION}
> during config (<Perl> sections) and the open_logs and post_config phases
> (where you said you were having trouble) and I can see it every time.
> yeah, I can see that it's actually set during post_config, but I'm hesitant
> to shuffle things around if I can't actually reproduce the problem in the
> first place.
You're right, Geoff. They do get populated at the server startup:
static void modperl_boot(pTHX_ void *data)
{
[...]
modperl_env_default_populate(aTHX);
(it just happens twice for some reason, I've missed that second population
happening in modperl_env_hash_keys, it probably happens due to un-tie of %ENV)
In which case checking $ENV{MOD_PERL_API_VERSION} should do the trick.
--
_____________________________________________________________
Stas Bekman mailto:stas@stason.org http://stason.org/
MailChannels: Assured Messaging(TM) http://mailchannels.com/
The "Practical mod_perl" book http://modperlbook.org/
http://perl.apache.org/ http://perl.org/ http://logilune.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> sorry, I meant to attach my test patch.
> Index: t/response/TestModperl/pnotes.pm
> ===================================================================
> --- t/response/TestModperl/pnotes.pm (revision 371539)
> +++ t/response/TestModperl/pnotes.pm (working copy)
and you can ignore this part.
never code on mondays or fridays...
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> hmm...
>
> I started to work on this but couldn't get it to fail as you describe.
> basically all I did was add code that looked for $ENV{MOD_PERL_API_VERSION}
> during config (<Perl> sections) and the open_logs and post_config phases
> (where you said you were having trouble) and I can see it every time.
>
> yeah, I can see that it's actually set during post_config, but I'm hesitant
> to shuffle things around if I can't actually reproduce the problem in the
> first place.
sorry, I meant to attach my test patch.
--Geoff
Re: issues with figuring out which mp version is running
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Stas Bekman wrote:
> Geoffrey Young wrote:
> [...]
>
>> but regardless, stas has a point - we need a definitive way to tell
>> whether
>> you are running under mp1 or mp2, then update the docs.
>>
>> my suggestion is to check for $ENV{MOD_PERL_API_VERSION}, which only
>> exists
>> in the official 2.0 API (mp 1.999_22 and later). if that isn't set at
>> the
>> earliest possible moment, before _any_ mod_perl hooks can be called,
>> then we
>> need to fix that.
>
>
> That's the case. It needs to be fixed. And so do the docs.
hmm...
I started to work on this but couldn't get it to fail as you describe.
basically all I did was add code that looked for $ENV{MOD_PERL_API_VERSION}
during config (<Perl> sections) and the open_logs and post_config phases
(where you said you were having trouble) and I can see it every time.
yeah, I can see that it's actually set during post_config, but I'm hesitant
to shuffle things around if I can't actually reproduce the problem in the
first place.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
[...]
> but regardless, stas has a point - we need a definitive way to tell whether
> you are running under mp1 or mp2, then update the docs.
>
> my suggestion is to check for $ENV{MOD_PERL_API_VERSION}, which only exists
> in the official 2.0 API (mp 1.999_22 and later). if that isn't set at the
> earliest possible moment, before _any_ mod_perl hooks can be called, then we
> need to fix that.
That's the case. It needs to be fixed. And so do the docs.
--
_____________________________________________________________
Stas Bekman mailto:stas@stason.org http://stason.org/
MailChannels: Assured Messaging(TM) http://mailchannels.com/
The "Practical mod_perl" book http://modperlbook.org/
http://perl.apache.org/ http://perl.org/ http://logilune.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> Sure in:
> http://search.cpan.org/src/FWILES/Apache-DB-0.10/lib/Apache/DProf.pm
>
> it goes:
>
> use constant MP2 => eval { require mod_perl; $mod_perl::VERSION > 1.99 };
>
> so MP2 can never be true,
never is an awfully long time :)
> since it should be mod_perl2 not mod_perl.
mod_perl2.pm has this
# this stuff is here to assist back compat
# basically, if you
# PerlModule mod_perl2
# or take similar steps to load mod_perl2 at
# startup you are protected against loading mod_perl.pm
# (either 1.0 or 1.99) at a later time by accident.
$mod_perl::VERSION = $mod_perl2::VERSION;
> Since I don't have mp1 installed (which I guess happens to work instead)
> the module doesn't work.
I guess the difference is that frank is loading some module somewhere that
loads mod_perl2.pm while you are not.
>
> FWIW, Apache::DB has 'require mod_perl2';
> http://search.cpan.org/src/FWILES/Apache-DB-0.10/DB.pm
and there is the difference.
but regardless, stas has a point - we need a definitive way to tell whether
you are running under mp1 or mp2, then update the docs.
my suggestion is to check for $ENV{MOD_PERL_API_VERSION}, which only exists
in the official 2.0 API (mp 1.999_22 and later). if that isn't set at the
earliest possible moment, before _any_ mod_perl hooks can be called, then we
need to fix that.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Stas Bekman <st...@stason.org>.
Philip M. Gollucci wrote:
>
>> use constant MP2 => eval { require mod_perl; $mod_perl::VERSION >
>> 1.99 };
>>
>> so MP2 can never be true, since it should be mod_perl2 not mod_perl.
>> Since I don't have mp1 installed (which I guess happens to work
>> instead) the module doesn't work.
>
>
> I've been out of the game for a while, but this is not true.
> In mod_perl2.pm this is specifically set to ease the porting effort.
It has nothing to do with mod_perl2.pm, the above snippet loads
mod_perl.pm. So if you haven't loaded mod_perl2.pm already the above code
will never be true.
--
_____________________________________________________________
Stas Bekman mailto:stas@stason.org http://stason.org/
MailChannels: Assured Messaging(TM) http://mailchannels.com/
The "Practical mod_perl" book http://modperlbook.org/
http://perl.apache.org/ http://perl.org/ http://logilune.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
> use constant MP2 => eval { require mod_perl; $mod_perl::VERSION >
> 1.99 };
>
> so MP2 can never be true, since it should be mod_perl2 not mod_perl.
> Since I don't have mp1 installed (which I guess happens to work
> instead) the module doesn't work.
I've been out of the game for a while, but this is not true.
In mod_perl2.pm this is specifically set to ease the porting effort.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Frank Wiles <fr...@wiles.org>.
On Sat, 21 Jan 2006 20:32:35 -0800
Stas Bekman <st...@stason.org> wrote:
> Sure in:
> http://search.cpan.org/src/FWILES/Apache-DB-0.10/lib/Apache/DProf.pm
>
> it goes:
>
> use constant MP2 => eval { require mod_perl; $mod_perl::VERSION >
> 1.99 };
>
> so MP2 can never be true, since it should be mod_perl2 not mod_perl.
> Since I don't have mp1 installed (which I guess happens to work
> instead) the module doesn't work.
>
> FWIW, Apache::DB has 'require mod_perl2';
> http://search.cpan.org/src/FWILES/Apache-DB-0.10/DB.pm
Ok now I'm *REALLY* confused. :) I just wrote up a small handler on
my system, just to test the use constant above, and indeed it fails,
however... Apache::DProf and Apache::SmallProf *work* just fine
my system.
I'd like to get this wrapped up asap, as I've got an article coming
out on perl.com in the next few weeks showing how to use these modules
and specifically with mp2.
I'm completely confused because if the MP2 test isn't working then
it shouldn't be loading in the proper libraries i.e.
Apache2::RequestRec and Apache2::ServerUtil, which is the whole
"point" of the port! ;)
At first I thought maybe I'd screwed myself up again by having
something preloaded, but this is all I have in my startup.pl other
than a use lib:
use APR::Pool;
use Apache::DB;
Apache::DB->init;
1;
Anyone got any ideas on what I should use instead of the constant
above?
---------------------------------
Frank Wiles <fr...@wiles.org>
http://www.wiles.org
---------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Stas Bekman <st...@stason.org>.
Frank Wiles wrote:
> On Fri, 20 Jan 2006 16:13:10 -0800
> Stas Bekman <st...@stason.org> wrote:
>
>
>>I'm trying to make Apache::DProf to work under mp2 and I thought the
>>following will work:
>>
>> die "mod_perl is required to run this module"
>> unless $ENV{MOD_PERL};
>> use constant MP2 => $ENV{MOD_PERL} >= 2;
>>
>>but no such luck, since $ENV{MOD_PERL} is set at the end of
>>post_config, and Apache::DProf loads during the config phase.
>>
>>I think setting of $ENV{MOD_PERL} needs to be moved to happen as soon
>>as perl starts and before we try to run any code or load any modules.
>
>
> Can you give me more info about how APache::DProf isn't working for
> you? I just used it yesterday in fact with MP 2.0.1 without any
> problems.
Sure in:
http://search.cpan.org/src/FWILES/Apache-DB-0.10/lib/Apache/DProf.pm
it goes:
use constant MP2 => eval { require mod_perl; $mod_perl::VERSION > 1.99 };
so MP2 can never be true, since it should be mod_perl2 not mod_perl. Since
I don't have mp1 installed (which I guess happens to work instead) the
module doesn't work.
FWIW, Apache::DB has 'require mod_perl2';
http://search.cpan.org/src/FWILES/Apache-DB-0.10/DB.pm
--
_____________________________________________________________
Stas Bekman mailto:stas@stason.org http://stason.org/
MailChannels: Assured Messaging(TM) http://mailchannels.com/
The "Practical mod_perl" book http://modperlbook.org/
http://perl.apache.org/ http://perl.org/ http://logilune.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: issues with figuring out which mp version is running
Posted by Frank Wiles <fr...@wiles.org>.
On Fri, 20 Jan 2006 16:13:10 -0800
Stas Bekman <st...@stason.org> wrote:
> I'm trying to make Apache::DProf to work under mp2 and I thought the
> following will work:
>
> die "mod_perl is required to run this module"
> unless $ENV{MOD_PERL};
> use constant MP2 => $ENV{MOD_PERL} >= 2;
>
> but no such luck, since $ENV{MOD_PERL} is set at the end of
> post_config, and Apache::DProf loads during the config phase.
>
> I think setting of $ENV{MOD_PERL} needs to be moved to happen as soon
> as perl starts and before we try to run any code or load any modules.
Can you give me more info about how APache::DProf isn't working for
you? I just used it yesterday in fact with MP 2.0.1 without any
problems.
---------------------------------
Frank Wiles <fr...@wiles.org>
http://www.wiles.org
---------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org