You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "ribeirompl (via GitHub)" <gi...@apache.org> on 2024/08/28 13:50:36 UTC

[PR] feat(dataZoom): change moveHandler cursor icon to move [echarts]

ribeirompl opened a new pull request, #20304:
URL: https://github.com/apache/echarts/pull/20304

   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [x] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Change cursor icon to more intuitive 'move', for dataZoom slider moveHandle
   
   
   ### Fixed issues
   
   - #20303
   
   ## Details
   
   ### Before: What was the problem?
   
   The Move/Drag icon is not intuitive, and it makes it difficult to know whether you're busy resizing or dragging, when the mouse is nearby the edge.
   
   | Original Move/Drag icon | New Move/Drag icon | 
   |--------|-------|
   |  ![bad_move](https://github.com/user-attachments/assets/2f20f190-a06a-4aac-953a-46eed6391fa9)  | ![suggested_move](https://github.com/user-attachments/assets/22796011-df87-4a8b-ba5c-fad830354116)  |
   
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   
   
   ## Misc
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   N.A.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

Re: [PR] feat(dataZoom): change moveHandler cursor icon to move [echarts]

Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia merged PR #20304:
URL: https://github.com/apache/echarts/pull/20304


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

Re: [PR] feat(dataZoom): change moveHandler cursor icon to move [echarts]

Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #20304:
URL: https://github.com/apache/echarts/pull/20304#issuecomment-2328296512

   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

Re: [PR] feat(dataZoom): change moveHandler cursor icon to move [echarts]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20304:
URL: https://github.com/apache/echarts/pull/20304#issuecomment-2328295036

   The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20304@7fe6fa2
   <!-- ECHARTS_PR_PREVIEW -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

Re: [PR] feat(dataZoom): change moveHandler cursor icon to move [echarts]

Posted by "ribeirompl (via GitHub)" <gi...@apache.org>.
ribeirompl commented on PR #20304:
URL: https://github.com/apache/echarts/pull/20304#issuecomment-2320738761

   I did some more research, and it appears that the main icon used for movement in a restricted container is the 'default' icon.
   
   The main examples are scrollbars, in browser windows or other applications:
   
   | Example scrollbar in Excel | Example scrollbar in VSCode |
   |------------------|----------------|
   | ![scrollbar_example1](https://github.com/user-attachments/assets/d408a384-35ce-41bf-afc3-833c942c2d4c) |  ![scrollbar_example2](https://github.com/user-attachments/assets/04edc788-9374-435b-8e7a-e67b4616fa04) |
   
   My main issue with the current icon, is for the case below:
   ![bad_case](https://github.com/user-attachments/assets/db0ae335-a4dd-40dc-8adf-e1959f154005)
   
   It is not obvious from a UX perspective, whether the mouse is going to resize or move the view. In the image above, if you shift the mouse 1 pixel up, then it will move the container, and 1 pixel down it will resize. But that slight movement has no visual changes/indication to the user as to what will happen. 
   
   Therefore I propose to change it to the 'default' icon, as used in scrollbars.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

Re: [PR] feat(dataZoom): change moveHandler cursor icon to move [echarts]

Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #20304:
URL: https://github.com/apache/echarts/pull/20304#issuecomment-2315377236

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org