You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by AiHe <gi...@git.apache.org> on 2015/04/28 21:09:03 UTC

[GitHub] spark pull request: [MLLIB] Add reservoir sample for feature in Ra...

GitHub user AiHe opened a pull request:

    https://github.com/apache/spark/pull/5752

    [MLLIB] Add reservoir sample for feature in RandomForest and fix other issues in tree

    1. Reservoir sample for feature
    2. Verify input rdd size > 0 when building DecisionTreeMetadata
    3. Fix other formatting issues

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AiHe/spark decisiontree-issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/5752.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5752
    
----
commit 0c7b3fc577a04ccc97a5a8e931779772d09cd9f7
Author: Alain <ai...@usc.edu>
Date:   2015-04-28T19:06:47Z

    [MLLIB] Add reservoir sample for feature in RandomForest and fix other issues in tree
    
    1. Reservoir sample for feature
    2. Verify input rdd size > 0
    3. Fix other formatting issues

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [MLLIB] Add reservoir sample for feature in Ra...

Posted by AiHe <gi...@git.apache.org>.
Github user AiHe commented on the pull request:

    https://github.com/apache/spark/pull/5752#issuecomment-97895236
  
    @srowen Sorry for this mixed RP. After reading the wiki, I guess I commit "Before proceeding, contributors should evaluate if the proposed change is likely to be relevant, new and actionable." I'll follow the wiki in feature's RP.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [MLLIB] Add reservoir sample for feature in Ra...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5752#issuecomment-97173241
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [MLLIB] Add reservoir sample for feature in Ra...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/5752#issuecomment-97174316
  
    Hey @AiHe this generally isn't how to propose changes. You're trying to intro a new feature and several changes that aren't quite related. Do you mind closing this PR and then review https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [MLLIB] Add reservoir sample for feature in Ra...

Posted by AiHe <gi...@git.apache.org>.
Github user AiHe closed the pull request at:

    https://github.com/apache/spark/pull/5752


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org