You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/05/22 12:57:59 UTC
(commons-collections) 15/16: Fix PMD UselessOverridingMethod in PropertiesFactory.EmptyProperties
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git
commit 77c25370a5998a5f9c069a2dc7e5e71f228ddccd
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed May 22 08:57:17 2024 -0400
Fix PMD UselessOverridingMethod in PropertiesFactory.EmptyProperties
---
src/changes/changes.xml | 1 +
.../collections4/properties/PropertiesFactory.java | 25 ----------------------
2 files changed, 1 insertion(+), 25 deletions(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index bd5b690a4..d51c1ed63 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -32,6 +32,7 @@
<action type="update" dev="ggregory" due-to="Gary Gregory">Deprecate Predicate in favor of java.util.function.Predicate.</action>
<action type="update" dev="ggregory" due-to="Gary Gregory">Deprecate Transformer in favor of java.util.function.Function.</action>
<action issue="COLLECTIONS-853" type="fix" dev="aherbert" due-to="Claude Warren, Alex Herbert, Gary Gregory">Change LayerManager to use List and added generics to LayerdedBloomFilter #481.</action>
+ <action type="update" dev="ggregory" due-to="PMD, Gary Gregory">Fix PMD UselessOverridingMethod in PropertiesFactory.EmptyProperties.</action>
<action type="update" dev="ggregory" due-to="PMD, Gary Gregory">Fix PMD UnnecessaryFullyQualifiedName in AbstractHashedMap.</action>
<action type="update" dev="ggregory" due-to="PMD, Gary Gregory">Fix PMD UnnecessaryFullyQualifiedName in AbstractLinkedMap.</action>
<action type="update" dev="ggregory" due-to="PMD, Gary Gregory">Fix PMD UnnecessaryFullyQualifiedName in CaseInsensitiveMap.</action>
diff --git a/src/main/java/org/apache/commons/collections4/properties/PropertiesFactory.java b/src/main/java/org/apache/commons/collections4/properties/PropertiesFactory.java
index ef6eef6bf..45e159c7a 100644
--- a/src/main/java/org/apache/commons/collections4/properties/PropertiesFactory.java
+++ b/src/main/java/org/apache/commons/collections4/properties/PropertiesFactory.java
@@ -21,7 +21,6 @@ import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.io.Reader;
-import java.io.Writer;
import java.util.Collection;
import java.util.Collections;
import java.util.Enumeration;
@@ -274,30 +273,6 @@ public class PropertiesFactory extends AbstractPropertiesFactory<Properties> {
return 0;
}
- @Override
- public void store(final OutputStream out, final String comments) throws IOException {
- // Implement as super
- super.store(out, comments);
- }
-
- @Override
- public void store(final Writer writer, final String comments) throws IOException {
- // Implement as super
- super.store(writer, comments);
- }
-
- @Override
- public void storeToXML(final OutputStream os, final String comment) throws IOException {
- // Implement as super
- super.storeToXML(os, comment);
- }
-
- @Override
- public void storeToXML(final OutputStream os, final String comment, final String encoding) throws IOException {
- // Implement as super
- super.storeToXML(os, comment, encoding);
- }
-
@Override
public Set<String> stringPropertyNames() {
return Collections.emptySet();