You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by ceefour <gi...@git.apache.org> on 2016/02/13 08:22:03 UTC
[GitHub] incubator-tinkerpop pull request: slf4j-log4j12 / log4j is only re...
GitHub user ceefour opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/229
slf4j-log4j12 / log4j is only required for testing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ceefour/incubator-tinkerpop patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #229
----
commit e720399478c79761cdf5578e45c41df10d095942
Author: Hendy Irawan <he...@hendyirawan.com>
Date: 2016-02-13T07:21:07Z
slf4j-log4j12 / log4j is only required for testing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: slf4j-log4j12 / log4j is only re...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/229#issuecomment-186262127
Also, when you do that, can you please target this change at the `tp31` branch? I think we'd want to see this change for `3.1.2-incubating`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: slf4j-log4j12 / log4j is only re...
Posted by ceefour <gi...@git.apache.org>.
Github user ceefour closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: slf4j-log4j12 / log4j is only re...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/229#issuecomment-186237810
I guess we shouldn't have log4j be a standard dependency for `gremlin-core`, given use of slf4j, but I'm not sure making it a test dependency is right. we package log4j by default in the `gremlin-console` and `gremlin-server`. maybe those slf4j implementations should be added to those project directly and they are made a test dependency here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: slf4j-log4j12 / log4j is only re...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/229#issuecomment-186249643
Cool - that makes sense - can you please amend your PR appropriately and take all the modules into account in doing so?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: slf4j-log4j12 / log4j is only re...
Posted by ceefour <gi...@git.apache.org>.
Github user ceefour commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/229#issuecomment-186244839
Yes, the "app" projects should have the runtime dependencies marked as "scope=runtime", and the "library" projects should have these dependencied marked as "scope=test"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: slf4j-log4j12 / log4j is only re...
Posted by ceefour <gi...@git.apache.org>.
Github user ceefour commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/229#issuecomment-186455720
Replaced by #233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---