[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4898: VM Snapshot: Prevent vm snapshots being indefinitely stuck in Expunging state on deletion failure

[GitBox <gi...@apache.org>]

harikrishna-patnala commented on a change in pull request #4898:
URL: https://github.com/apache/cloudstack/pull/4898#discussion_r609326606



##########
File path: api/src/main/java/com/cloud/vm/snapshot/VMSnapshot.java
##########
@@ -59,6 +59,7 @@ public String getDescription() {
             s_fsm.addTransition(Error, Event.ExpungeRequested, Expunging);
             s_fsm.addTransition(Expunging, Event.ExpungeRequested, Expunging);
             s_fsm.addTransition(Expunging, Event.OperationSucceeded, Removed);
+            s_fsm.addTransition(Expunging, Event.OperationFailed, Ready);

Review comment:
       @Pearl1594 Setting to error state should be fine I think. User or admin can retry deletion of the VM snapshots again. We already have the transition in place. `s_fsm.addTransition(Error, Event.ExpungeRequested, Expunging);`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org