You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2016/10/18 18:04:53 UTC
[GitHub] incubator-beam pull request #1128: [BEAM-771] Add a Residual Shard for Empty...
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/1128
[BEAM-771] Add a Residual Shard for Empty Readers
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
When the UnboundedReadEvaluator starts, it checks to see if the reader
has any elements available. If not, it immediately terminates (without
taking a new checkpoint). It should also ensure that the result contains
a residual shard that will continue to read from the shard, utilizing
the same reader if possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam read_when_no_inputs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1128
----
commit 87f26972c02bb7640c1eee5069ad842a4a3ab1a0
Author: Thomas Groh <tg...@google.com>
Date: 2016-10-18T17:57:53Z
Add a Residual Shard for Empty Readers
When the UnboundedReadEvaluator starts, it checks to see if the reader
has any elements available. If not, it immediately terminates (without
taking a new checkpoint). It should also ensure that the result contains
a residual shard that will continue to read from the shard, utilizing
the same reader if possible.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1128: [BEAM-771] Add a Residual Shard for Empty...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/1128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---