[GitHub] [beam] bvolpato commented on a diff in pull request #26752: Only use updated schema if auto update is enabled

["bvolpato (via GitHub)" <gi...@apache.org>]

bvolpato commented on code in PR #26752:
URL: https://github.com/apache/beam/pull/26752#discussion_r1198080749


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java:
##########
@@ -691,7 +691,7 @@ void postFlush() {
           @Nullable
           TableSchema updatedTableSchema =

Review Comment:
   Thanks!
   
   This would make it clearer, but not needed here for now -- `streamAppendClient.getUpdatedSchema()` does not make external calls, it's pulling a reference that already exists, so there's no practical difference for changing this.
   
   We'll be addressing the bug when the update has to actually happen as part of another PR, and we can consider this path there. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org