You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jun Rao (JIRA)" <ji...@apache.org> on 2011/08/17 19:40:27 UTC

[jira] [Created] (KAFKA-108) A new unit test for ByteBufferMessageSet iterator

A new unit test for ByteBufferMessageSet iterator
-------------------------------------------------

                 Key: KAFKA-108
                 URL: https://issues.apache.org/jira/browse/KAFKA-108
             Project: Kafka
          Issue Type: Test
            Reporter: Jun Rao
            Assignee: Jun Rao


We need to add a unit test that iterates ByteBufferMessageSet with compression and without. Also, test that ByteBufferMessageSet can be iterated multiple times.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (KAFKA-108) A new unit test for ByteBufferMessageSet iterator

Posted by "Neha Narkhede (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KAFKA-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087423#comment-13087423 ] 

Neha Narkhede commented on KAFKA-108:
-------------------------------------

+1. All tests look good.

> A new unit test for ByteBufferMessageSet iterator
> -------------------------------------------------
>
>                 Key: KAFKA-108
>                 URL: https://issues.apache.org/jira/browse/KAFKA-108
>             Project: Kafka
>          Issue Type: Test
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>         Attachments: kafka-108.patch, kafka-108.patch.v2
>
>
> We need to add a unit test that iterates ByteBufferMessageSet with compression and without. Also, test that ByteBufferMessageSet can be iterated multiple times.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (KAFKA-108) A new unit test for ByteBufferMessageSet iterator

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao updated KAFKA-108:
--------------------------

    Attachment: kafka-108.patch

Patch attached.

> A new unit test for ByteBufferMessageSet iterator
> -------------------------------------------------
>
>                 Key: KAFKA-108
>                 URL: https://issues.apache.org/jira/browse/KAFKA-108
>             Project: Kafka
>          Issue Type: Test
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>         Attachments: kafka-108.patch
>
>
> We need to add a unit test that iterates ByteBufferMessageSet with compression and without. Also, test that ByteBufferMessageSet can be iterated multiple times.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (KAFKA-108) A new unit test for ByteBufferMessageSet iterator

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao updated KAFKA-108:
--------------------------

    Attachment: kafka-108.patch.v2

Attaching patch v2. The unit test fails and exposes a bug on handling compressed empty ByteBufferMessageSet.

> A new unit test for ByteBufferMessageSet iterator
> -------------------------------------------------
>
>                 Key: KAFKA-108
>                 URL: https://issues.apache.org/jira/browse/KAFKA-108
>             Project: Kafka
>          Issue Type: Test
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>         Attachments: kafka-108.patch, kafka-108.patch.v2
>
>
> We need to add a unit test that iterates ByteBufferMessageSet with compression and without. Also, test that ByteBufferMessageSet can be iterated multiple times.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (KAFKA-108) A new unit test for ByteBufferMessageSet iterator

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao updated KAFKA-108:
--------------------------

    Status: Patch Available  (was: Open)

> A new unit test for ByteBufferMessageSet iterator
> -------------------------------------------------
>
>                 Key: KAFKA-108
>                 URL: https://issues.apache.org/jira/browse/KAFKA-108
>             Project: Kafka
>          Issue Type: Test
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>         Attachments: kafka-108.patch
>
>
> We need to add a unit test that iterates ByteBufferMessageSet with compression and without. Also, test that ByteBufferMessageSet can be iterated multiple times.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (KAFKA-108) A new unit test for ByteBufferMessageSet iterator

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao updated KAFKA-108:
--------------------------

       Resolution: Fixed
    Fix Version/s: 0.7
           Status: Resolved  (was: Patch Available)

> A new unit test for ByteBufferMessageSet iterator
> -------------------------------------------------
>
>                 Key: KAFKA-108
>                 URL: https://issues.apache.org/jira/browse/KAFKA-108
>             Project: Kafka
>          Issue Type: Test
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>             Fix For: 0.7
>
>         Attachments: kafka-108.patch, kafka-108.patch.v2
>
>
> We need to add a unit test that iterates ByteBufferMessageSet with compression and without. Also, test that ByteBufferMessageSet can be iterated multiple times.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira