You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/21 19:57:38 UTC

[GitHub] [spark] tdg5 opened a new pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

tdg5 opened a new pull request #34979:
URL: https://github.com/apache/spark/pull/34979


   ### What changes were proposed in this pull request?
   These are a couple of changes I found worthwhile while running docker integration tests for https://github.com/apache/spark/pull/34745.
   
   The doc changes are minor fixes to add the missing repository to the suggested command to run the docker integration tests.
   
   The library change relates to this comment: https://github.com/apache/spark/pull/34745#discussion_r773084417; I don't know if my testing was thorough enough, but I found that the referenced dependency was not needed and could be removed.
   
   ### Why are the changes needed?
   The doc changes are needed because the current suggested command is missing the docker repository so will not work in its current state. 
   
   The library removal is needed because the build fails when the `ojdbc6` package is included because the referenced library is no longer available in jfrog: https://camunda.jfrog.io/ui/native/public/com/oracle/ojdbc6
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Attempted to run all the docker integration tests locally by running
   ```
   ENABLE_DOCKER_INTEGRATION_TESTS=1 ./build/sbt -Pdocker-integration-tests "testOnly *IntegrationSuite"
   ```
   Assuming this didn't miss any tests, all the tests passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999055715


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000022962


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146497/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] tdg5 edited a comment on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
tdg5 edited a comment on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999055984


   @sarutak , I pulled these changes (with modifications based on your feedback) out of https://github.com/apache/spark/pull/34745. Let me know if I've missed anything. Thanks for pointing out that the other image changes weren't needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000004000


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50973/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999241904


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146456/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999966503


   **[Test build #146497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146497/testReport)** for PR 34979 at commit [`c7b279b`](https://github.com/apache/spark/commit/c7b279b5c0707ba77344d00e36e6cf14e708b2dd).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999966503


   **[Test build #146497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146497/testReport)** for PR 34979 at commit [`c7b279b`](https://github.com/apache/spark/commit/c7b279b5c0707ba77344d00e36e6cf14e708b2dd).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000656566


   **[Test build #146546 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146546/testReport)** for PR 34979 at commit [`c7b279b`](https://github.com/apache/spark/commit/c7b279b5c0707ba77344d00e36e6cf14e708b2dd).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000022962


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146497/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000255168


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000004000


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50973/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999153307


   ok to test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999169808


   **[Test build #146456 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146456/testReport)** for PR 34979 at commit [`c7b279b`](https://github.com/apache/spark/commit/c7b279b5c0707ba77344d00e36e6cf14e708b2dd).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999188748


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50931/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999218129


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50931/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000658492


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146546/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun closed pull request #34979: [SPARK-37715][SQL][BUILD][TESTS] Remove `ojdbc6` dependency and update docker-integration test docs

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #34979:
URL: https://github.com/apache/spark/pull/34979


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000030121


   @tdg5 
   ```
   The library removal is needed because the build fails when the ojdbc6 package is included because the referenced library is no longer available in jfrog: https://camunda.jfrog.io/ui/native/public/com/oracle/ojdbc6
   ```
   I think that the more justified reason to remove `odbc6` is it no longer used by Spark right?
   Spark uses ojdbc8 for docker-integration-tests whose setting is in `pom.xml`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000636492


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51021/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000623665


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51021/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000255168


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999979832


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50973/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000637378


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51021/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000610132


   **[Test build #146546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146546/testReport)** for PR 34979 at commit [`c7b279b`](https://github.com/apache/spark/commit/c7b279b5c0707ba77344d00e36e6cf14e708b2dd).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] tdg5 commented on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
tdg5 commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999055984


   @sarutak , I pulled these changes (with modifications based on your feedback) out of https://github.com/apache/spark/pull/34745. Let me know if I've missed anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999055715


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999241904


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146456/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000018655


   **[Test build #146497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146497/testReport)** for PR 34979 at commit [`c7b279b`](https://github.com/apache/spark/commit/c7b279b5c0707ba77344d00e36e6cf14e708b2dd).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000637378


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51021/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] tdg5 commented on pull request #34979: [Spark-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
tdg5 commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999852858


   @sarutak , JIRA created and title updated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #34979: [Spark-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999957037


   ok to test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999218129


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50931/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000609305


   ok to test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000658492


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146546/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999356511


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000001776


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50973/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999356511


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34979: [SPARK-37715][SQL][BUILD]Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-1000610132


   **[Test build #146546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146546/testReport)** for PR 34979 at commit [`c7b279b`](https://github.com/apache/spark/commit/c7b279b5c0707ba77344d00e36e6cf14e708b2dd).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999237678


   **[Test build #146456 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146456/testReport)** for PR 34979 at commit [`c7b279b`](https://github.com/apache/spark/commit/c7b279b5c0707ba77344d00e36e6cf14e708b2dd).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999169808


   **[Test build #146456 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146456/testReport)** for PR 34979 at commit [`c7b279b`](https://github.com/apache/spark/commit/c7b279b5c0707ba77344d00e36e6cf14e708b2dd).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999154677


   @tdg5 This PR changes not only comments but also the build definition (`SparkBuild.scala`). So, could you file a JIRA just in case, and modify the title of this PR like `[SPARK-XXXX][SQL][BUILD]...` ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34979: Docker integration tests: Tweak docs and remove unneeded dependency

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34979:
URL: https://github.com/apache/spark/pull/34979#issuecomment-999212411


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50931/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org