[GitHub] [trafficserver] bneradt commented on a diff in pull request #9632: Fix Proxy Protocol outbound

["bneradt (via GitHub)" <gi...@apache.org>]

bneradt commented on code in PR #9632:
URL: https://github.com/apache/trafficserver/pull/9632#discussion_r1175495074


##########
proxy/http/ConnectingEntry.cc:
##########
@@ -49,12 +49,16 @@ ConnectingEntry::state_http_server_open(int event, void *data)
     // The buffer we create will be handed over to the eventually created server session
     _netvc_read_buffer = new_MIOBuffer(HTTP_SERVER_RESP_HDR_BUFFER_INDEX);
     _netvc_reader      = _netvc_read_buffer->alloc_reader();
-    netvc->do_io_write(this, 1, _netvc_reader);
     ink_release_assert(!connect_sms.empty());
-    if (!connect_sms.empty()) {
-      HttpSM *prime_connect_sm = *(connect_sms.begin());
-      netvc->set_inactivity_timeout(prime_connect_sm->get_server_connect_timeout());
+    HttpSM *prime_connect_sm = *(connect_sms.begin());
+
+    int64_t nbytes = 1;
+    if (is_no_plugin_tunnel && prime_connect_sm->t_state.txn_conf->proxy_protocol_out >= 0) {
+      nbytes = do_outbound_proxy_protocol(_netvc_reader->mbuf, vc, ua_txn->get_netvc(),
+                                          prime_connect_sm->t_state.txn_conf->proxy_protocol_out);

Review Comment:
   Right, empirically anyway that's what I observe. By the time the EVENT_TXN is done (where it was before), it seems too late to add the Proxy Protocol header because no header is emitted if we attempt to add it there. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org