You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/18 12:20:00 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #10980: [Bug][Array] cast array element to same type
BiteTheDDDDt opened a new pull request, #10980:
URL: https://github.com/apache/doris/pull/10980
# Proposed changes
Issue Number: close #10978
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on pull request #10980: [Bug][Array] cast array element to same type
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #10980:
URL: https://github.com/apache/doris/pull/10980#issuecomment-1188657754
FE UT need to fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on pull request #10980: [Bug][Array] cast array element to same type
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #10980:
URL: https://github.com/apache/doris/pull/10980#issuecomment-1188656420
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10980: [Bug][Array] cast array element to same type
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10980:
URL: https://github.com/apache/doris/pull/10980#issuecomment-1189076710
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10980: [Bug][Array] cast array element to same type
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10980:
URL: https://github.com/apache/doris/pull/10980#issuecomment-1189076779
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #10980: [Bug][Array] cast array element to same type
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #10980:
URL: https://github.com/apache/doris/pull/10980#discussion_r923375078
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ArrayLiteral.java:
##########
@@ -39,20 +38,28 @@ public ArrayLiteral() {
children = new ArrayList<>();
}
- public ArrayLiteral(LiteralExpr... v) {
+ public ArrayLiteral(LiteralExpr... exprs) throws AnalysisException {
Type itemType = Type.NULL;
boolean containsNull = false;
- for (LiteralExpr expr : v) {
- if (itemType == Type.NULL || expr.type.getSlotSize() > itemType.getSlotSize()) {
- itemType = expr.type;
+ for (LiteralExpr expr : exprs) {
+ if (itemType == Type.NULL || expr.getType().getSlotSize() > itemType.getSlotSize()) {
Review Comment:
use `getAssignmentCompatibleType` is better than use `getSlotSize`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on pull request #10980: [Bug][Array] cast array element to same type
Posted by GitBox <gi...@apache.org>.
eldenmoon commented on PR #10980:
URL: https://github.com/apache/doris/pull/10980#issuecomment-1188742378
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #10980: [Bug][Array] cast array element to same type
Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #10980:
URL: https://github.com/apache/doris/pull/10980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org