You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/05 21:59:15 UTC
[GitHub] [pulsar] Dishwasha opened a new pull request #7516: Add support for partitioned tables
Dishwasha opened a new pull request #7516:
URL: https://github.com/apache/pulsar/pull/7516
### Motivation
Databases like PostgreSQL support table partitioning which will
cause the table not to be found in getTableId for jdbc sink/sources.
### Modifications
Adding "PARTITIONED TABLE" to the types passed to getTables fixes this.
### Verifying this change
Unfortunately the test suite doesn't pass for me even before this change,
but I ran the following after re-building the connector and no longer get
the table not found message.
```bin/pulsar-admin sinks create --tenant mytenant--namespace mynamespace --name mysink --archive ./connectors/pulsar-io-jdbc-postgres-2.6.0.nar --inputs mytopic --sink-config-file ./connectors/postgres.yaml --processingGuarantees EFFECTIVELY_ONCE --parallelism 1```
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
### Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? not applicable
- If a feature is not applicable for documentation, explain why?
Supporting partitioned tables shouldn't have to be specifically mentioned in documentation
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Dishwasha commented on pull request #7516: Add support for partitioned tables
Posted by GitBox <gi...@apache.org>.
Dishwasha commented on pull request #7516:
URL: https://github.com/apache/pulsar/pull/7516#issuecomment-725625478
Thank you @codelipenghui, though it looks like tests are failing even worse now. Closing in favor of https://github.com/apache/pulsar/pull/8527.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7516: Add support for partitioned tables
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7516:
URL: https://github.com/apache/pulsar/pull/7516#issuecomment-721453827
@Dishwasha Could you please rebase to the current master branch since there are some flaky tests fixes? And it's better to create a new branch when start working on a bug fix or feature development so that the committers can merge to the current master branch to your branch, the committers can't merge to your master branch because of the permissions rejection.
For more details about the contributing, you can see http://pulsar.apache.org/en/contributing/.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7516: Add support for partitioned tables
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7516:
URL: https://github.com/apache/pulsar/pull/7516#issuecomment-659830427
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Dishwasha closed pull request #7516: Add support for partitioned tables
Posted by GitBox <gi...@apache.org>.
Dishwasha closed pull request #7516:
URL: https://github.com/apache/pulsar/pull/7516
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Dishwasha commented on pull request #7516: Add support for partitioned tables
Posted by GitBox <gi...@apache.org>.
Dishwasha commented on pull request #7516:
URL: https://github.com/apache/pulsar/pull/7516#issuecomment-687874715
@sijie As I suspected, these CI/CD tests are extremely buggy and not caused by my change. Most of them appear to be timeout issues. I've added a commit that literally turns this PR in to a small whitespace change. What can we do to get this change merged? I can revert my second commit once I have guidance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Dishwasha commented on pull request #7516: Add support for partitioned tables
Posted by GitBox <gi...@apache.org>.
Dishwasha commented on pull request #7516:
URL: https://github.com/apache/pulsar/pull/7516#issuecomment-657157586
The failing tests seem likely to be a pre-existing problem with antiafinity and unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Dishwasha commented on pull request #7516: Add support for partitioned tables
Posted by GitBox <gi...@apache.org>.
Dishwasha commented on pull request #7516:
URL: https://github.com/apache/pulsar/pull/7516#issuecomment-687676839
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Dishwasha closed pull request #7516: Add support for partitioned tables
Posted by GitBox <gi...@apache.org>.
Dishwasha closed pull request #7516:
URL: https://github.com/apache/pulsar/pull/7516
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Dishwasha commented on pull request #7516: Add support for partitioned tables
Posted by GitBox <gi...@apache.org>.
Dishwasha commented on pull request #7516:
URL: https://github.com/apache/pulsar/pull/7516#issuecomment-687668371
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org