You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "tomsun28 (via GitHub)" <gi...@apache.org> on 2023/09/18 04:53:35 UTC
[GitHub] [shenyu] tomsun28 opened a new pull request, #5168: remove alert data queue and bugfix cpu surge
tomsun28 opened a new pull request, #5168:
URL: https://github.com/apache/shenyu/pull/5168
<!-- Describe your PR here; eg. Fixes #issueNo -->
- remove alert data queue and fix cpu surge
- add AlarmSender.alarm use note
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #5168: remove alert data queue and bugfix cpu surge
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5168:
URL: https://github.com/apache/shenyu/pull/5168#issuecomment-1722774041
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5168?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5168](https://app.codecov.io/gh/apache/shenyu/pull/5168?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bb45dea) into [master](https://app.codecov.io/gh/apache/shenyu/commit/31241b737fb42336ccb1d5b0b693035cff1db51c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (31241b7) will **decrease** coverage by `0.10%`.
> The diff coverage is `30.00%`.
```diff
@@ Coverage Diff @@
## master #5168 +/- ##
============================================
- Coverage 60.86% 60.77% -0.10%
+ Complexity 8469 8457 -12
============================================
Files 1242 1242
Lines 37433 37428 -5
Branches 3532 3526 -6
============================================
- Hits 22785 22747 -38
- Misses 12692 12717 +25
- Partials 1956 1964 +8
```
| [Files Changed](https://app.codecov.io/gh/apache/shenyu/pull/5168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...g/apache/shenyu/plugin/base/alert/AlarmSender.java](https://app.codecov.io/gh/apache/shenyu/pull/5168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYmFzZS9hbGVydC9BbGFybVNlbmRlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...nyu/plugin/base/alert/AlarmThreadPoolExecutor.java](https://app.codecov.io/gh/apache/shenyu/pull/5168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYmFzZS9hbGVydC9BbGFybVRocmVhZFBvb2xFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...u/admin/service/impl/AlertDispatchServiceImpl.java](https://app.codecov.io/gh/apache/shenyu/pull/5168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL0FsZXJ0RGlzcGF0Y2hTZXJ2aWNlSW1wbC5qYXZh) | `19.40% <31.57%> (-7.36%)` | :arrow_down: |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5168/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] moremind merged pull request #5168: remove alert data queue and bugfix cpu surge
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind merged PR #5168:
URL: https://github.com/apache/shenyu/pull/5168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org