You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org> on 2024/01/16 21:23:26 UTC
[Impala-ASF-CR] Adds the ability for users to specify that Impala will create and maintain an internal Iceberg table that contains data about all completed queries. This table is automatically created at startup by each coordinator if it does not exist. Then, most comple
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: Adds the ability for users to specify that Impala will create and maintain an internal Iceberg table that contains data about all completed queries. This table is automatically created at startup by each coordinator if it does not exist. Then, most comple
......................................................................
Patch Set 5:
(28 comments)
http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/query-state.cc
File be/src/service/query-state.cc:
http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/query-state.cc@155
PS5, Line 155: this->per_host_mem_estimate = exec_state.exec_request().query_exec_request.per_host_mem_estimate;
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/query-state.cc@156
PS5, Line 156: this->max_per_host_min_mem_reservation = exec_state.exec_request().query_exec_request.max_per_host_min_mem_reservation;
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/query-state.cc@157
PS5, Line 157: this->max_per_host_thread_reservation = exec_state.exec_request().query_exec_request.max_per_host_thread_reservation;
line too long (119 > 90)
http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/query-state.cc@158
PS5, Line 158: this->dedicated_coord_mem_estimate = exec_state.exec_request().query_exec_request.dedicated_coord_mem_estimate;
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/workload-management.cc
File be/src/service/workload-management.cc:
http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/workload-management.cc@227
PS5, Line 227: *ctx->sql_ << "'" << PrintId(ctx->record_->id) << "'";
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/20770/5/be/src/service/workload-management.cc@406
PS5, Line 406: /// table. This portion of the statement is constant and thus is only generated once.
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py
File tests/custom_cluster/test_query_log.py:
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@38
PS5, Line 38: class TestQueryLogTable(CustomClusterTestSuite):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@55
PS5, Line 55: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@279
PS5, Line 279: #
flake8: E303 too many blank lines (2)
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@283
PS5, Line 283: @
flake8: E301 expected 1 blank line, found 0
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@318
PS5, Line 318: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@339
PS5, Line 339: e
flake8: F841 local variable 'e' is assigned to but never used
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@344
PS5, Line 344: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@384
PS5, Line 384: e
flake8: F841 local variable 'e' is assigned to but never used
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@538
PS5, Line 538: @
flake8: E301 expected 1 blank line, found 0
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@540
PS5, Line 540: +
flake8: W504 line break after binary operator
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@577
PS5, Line 577: =
flake8: E225 missing whitespace around operator
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@578
PS5, Line 578: @
flake8: E301 expected 1 blank line, found 0
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@610
PS5, Line 610: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@631
PS5, Line 631: @
flake8: E301 expected 1 blank line, found 0
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/custom_cluster/test_query_log.py@670
PS5, Line 670:
flake8: W292 no newline at end of file
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/util/retry.py
File tests/util/retry.py:
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/util/retry.py@22
PS5, Line 22: def retry(func, max_attempts=3, sleep_time_s=1, backoff=2, raise_immediately=False):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/util/retry.py@69
PS5, Line 69: -
flake8: E226 missing whitespace around arithmetic operator
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/util/retry.py@85
PS5, Line 85:
flake8: W293 blank line contains whitespace
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/util/retry.py@85
PS5, Line 85:
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/util/retry.py@87
PS5, Line 87:
flake8: W293 blank line contains whitespace
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/util/retry.py@87
PS5, Line 87:
flake8: W292 no newline at end of file
http://gerrit.cloudera.org:8080/#/c/20770/5/tests/util/retry.py@87
PS5, Line 87:
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/20770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844
Gerrit-Change-Number: 20770
Gerrit-PatchSet: 5
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jan 2024 21:23:26 +0000
Gerrit-HasComments: Yes