You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/26 09:33:40 UTC
[GitHub] [hbase] bsglz opened a new pull request #2319: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.curre…
bsglz opened a new pull request #2319:
URL: https://github.com/apache/hbase/pull/2319
…ntTimeMillis() in CurrentHourProvider
(cherry picked from commit f3c114d945c9338b484a16eb936455080e944aa4)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2319: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.curre…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2319:
URL: https://github.com/apache/hbase/pull/2319#issuecomment-680927206
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 45s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 10m 24s | branch-1 passed |
| +1 :green_heart: | compile | 0m 50s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 1s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 2m 13s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 50s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 54s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 0m 51s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 58s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 55s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 30s | the patch passed |
| +1 :green_heart: | compile | 0m 51s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javac | 0m 51s | the patch passed |
| +1 :green_heart: | compile | 0m 56s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | javac | 0m 56s | the patch passed |
| -1 :x: | checkstyle | 1m 56s | hbase-server: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 54s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 6m 1s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 38s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 0m 50s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 3m 57s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 134m 2s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. |
| | | 185m 23s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2319 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 33445e9fa81f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2319/out/precommit/personality/provided.sh |
| git revision | branch-1 / 8f946be |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/2/artifact/out/diff-checkstyle-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/2/testReport/ |
| Max. process+thread count | 4450 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/2/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2319: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.curre…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2319:
URL: https://github.com/apache/hbase/pull/2319#issuecomment-680809566
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 12m 10s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 1s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 53s | branch-1 passed |
| +1 :green_heart: | compile | 0m 44s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 0m 56s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 2m 11s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 24s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 58s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 0m 51s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 21s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 18s | branch-1 passed |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 1m 12s | root in the patch failed. |
| -1 :x: | compile | 0m 27s | hbase-server in the patch failed with JDK v1.8.0_262. |
| -1 :x: | javac | 0m 27s | hbase-server in the patch failed with JDK v1.8.0_262. |
| -1 :x: | compile | 0m 32s | hbase-server in the patch failed with JDK v1.7.0_272. |
| -1 :x: | javac | 0m 32s | hbase-server in the patch failed with JDK v1.7.0_272. |
| -1 :x: | checkstyle | 1m 44s | hbase-server: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | shadedjars | 1m 54s | patch has 22 errors when building our shaded downstream artifacts. |
| -1 :x: | hadoopcheck | 1m 7s | The patch causes 22 errors with Hadoop v2.8.5. |
| -1 :x: | hadoopcheck | 2m 54s | The patch causes 22 errors with Hadoop v2.9.2. |
| -1 :x: | javadoc | 0m 35s | hbase-server-jdk1.8.0_262 with JDK v1.8.0_262 generated 3 new + 8 unchanged - 0 fixed = 11 total (was 8) |
| -1 :x: | javadoc | 0m 42s | hbase-server-jdk1.7.0_272 with JDK v1.7.0_272 generated 3 new + 8 unchanged - 0 fixed = 11 total (was 8) |
| -1 :x: | findbugs | 0m 29s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 31s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
| | | 47m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2319 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 91a139d6c7bb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2319/out/precommit/personality/provided.sh |
| git revision | branch-1 / 8f946be |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/patch-compile-hbase-server-jdk1.8.0_262.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/patch-compile-hbase-server-jdk1.8.0_262.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/patch-compile-hbase-server-jdk1.7.0_272.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/patch-compile-hbase-server-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/diff-checkstyle-hbase-server.txt |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/patch-shadedjars.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/patch-javac-2.8.5.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/patch-javac-2.9.2.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/diff-javadoc-javadoc-hbase-server-jdk1.8.0_262.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/diff-javadoc-javadoc-hbase-server-jdk1.7.0_272.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/patch-findbugs-hbase-server.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/testReport/ |
| Max. process+thread count | 77 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2319: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.curre…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2319:
URL: https://github.com/apache/hbase/pull/2319#issuecomment-681543338
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 10s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 52s | branch-1 passed |
| +1 :green_heart: | compile | 0m 43s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 0m 48s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 2m 5s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 18s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 50s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 0m 42s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 12s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 8s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 3s | the patch passed |
| +1 :green_heart: | compile | 0m 41s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javac | 0m 41s | the patch passed |
| +1 :green_heart: | compile | 0m 47s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | javac | 0m 47s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 42s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 4s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 57s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 33s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 0m 43s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 3m 10s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 165m 10s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. |
| | | 209m 57s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2319 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 8368b87c57f4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2319/out/precommit/personality/provided.sh |
| git revision | branch-1 / 8f946be |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/3/testReport/ |
| Max. process+thread count | 4409 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2319/3/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani closed pull request #2319: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.curre…
Posted by GitBox <gi...@apache.org>.
virajjasani closed pull request #2319:
URL: https://github.com/apache/hbase/pull/2319
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org