You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dilli Dorai <di...@gmail.com> on 2015/11/05 16:26:00 UTC
REST API code review
Rangers,
Would like to suggest some good practice while submitting code review for
REST API changes.
Please include curl calls for success case and failure case and show the
outputs in code review Testing Done section.
This would make it clear what is being addressed and help to get better
code review.
Anyone supporting this suggestion?
Thanks
Dilli
Re: REST API code review
Posted by Dilli Dorai <di...@gmail.com>.
Selva,
Would like to do that and spend more time on Ranger.
However, limited by time constraints due to my commitments to my employer.
Would alert dev list if I notice anything that could be improved.
Thanks
Dilli
On Thu, Nov 5, 2015 at 7:33 AM, Selvamohan Neethiraj <sn...@apache.org>
wrote:
> +1
>
> Definitely will make it easy to review code …
>
> Thanks for the suggestion Dilli, Would you be able to update the Ranger
> Wiki with the good coding practices ?
>
> Thanks,
> Selva-
>
> From: Dilli Dorai <di...@gmail.com>
> Reply-To: "dev@ranger.incubator.apache.org" <
> dev@ranger.incubator.apache.org>
> Date: Thursday, November 5, 2015 at 10:26 AM
> To: "dev@ranger.incubator.apache.org" <de...@ranger.incubator.apache.org>
> Subject: REST API code review
>
> Rangers,
>
> Would like to suggest some good practice while submitting code review for
> REST API changes.
>
> Please include curl calls for success case and failure case and show the
> outputs in code review Testing Done section.
>
> This would make it clear what is being addressed and help to get better
> code review.
>
> Anyone supporting this suggestion?
>
> Thanks
> Dilli
>
>
>
Re: REST API code review
Posted by Selvamohan Neethiraj <sn...@apache.org>.
+1
Definitely will make it easy to review code …
Thanks for the suggestion Dilli, Would you be able to update the Ranger Wiki with the good coding practices ?
Thanks,
Selva-
From: Dilli Dorai <di...@gmail.com>
Reply-To: "dev@ranger.incubator.apache.org" <de...@ranger.incubator.apache.org>
Date: Thursday, November 5, 2015 at 10:26 AM
To: "dev@ranger.incubator.apache.org" <de...@ranger.incubator.apache.org>
Subject: REST API code review
Rangers,
Would like to suggest some good practice while submitting code review for
REST API changes.
Please include curl calls for success case and failure case and show the
outputs in code review Testing Done section.
This would make it clear what is being addressed and help to get better
code review.
Anyone supporting this suggestion?
Thanks
Dilli
Re: REST API code review
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
+1
Good suggestion Dilli.
On 11/5/15, 10:26 AM, "Dilli Dorai" <di...@gmail.com> wrote:
>Rangers,
>
>Would like to suggest some good practice while submitting code review for
>REST API changes.
>
>Please include curl calls for success case and failure case and show the
>outputs in code review Testing Done section.
>
>This would make it clear what is being addressed and help to get better
>code review.
>
>Anyone supporting this suggestion?
>
>Thanks
>Dilli