You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/08/07 16:24:41 UTC
[kudu-CR] wip consensus: atomicize timestamp/opid assignment
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11144
Change subject: wip consensus: atomicize timestamp/opid assignment
......................................................................
wip consensus: atomicize timestamp/opid assignment
This patch atomicizes timestamp assignment with respect to OpIds by
moving the assignment of timestamps into the RaftConsensus module, right
before operations are appended to the consensus queue to be sent to the
peers.
This patch adds test cases for timestamp serialization:
1. a test that writes data while triggering many change configs
2. a test that writes data while barraging the PingConsensus endpoint to
replicate a no-op, circumventing any kind of serialization
WIP: dependent on the previous patch (PingConsensus RPC)
Change-Id: Id347847d117509b0eadedcb4117b4e781f6e3654
---
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/integration-tests/timestamp_serialization-itest.cc
M src/kudu/tablet/transactions/transaction_driver.cc
4 files changed, 168 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/11144/1
--
To view, visit http://gerrit.cloudera.org:8080/11144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id347847d117509b0eadedcb4117b4e781f6e3654
Gerrit-Change-Number: 11144
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] consensus: atomicize timestamp/opid assignment
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11144
to look at the new patch set (#3).
Change subject: consensus: atomicize timestamp/opid assignment
......................................................................
consensus: atomicize timestamp/opid assignment
This patch atomicizes timestamp assignment with respect to OpIds by
moving the assignment of timestamps into the RaftConsensus module, right
before operations are appended to the consensus queue to be sent to the
peers.
This patch adds test cases for timestamp serialization:
1. a test that writes data while triggering many change configs
2. a test that writes data while barraging the PingConsensus endpoint to
replicate a no-op, circumventing any kind of serialization
Change-Id: Id347847d117509b0eadedcb4117b4e781f6e3654
---
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/integration-tests/timestamp_serialization-itest.cc
M src/kudu/tablet/transactions/transaction_driver.cc
4 files changed, 168 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/11144/3
--
To view, visit http://gerrit.cloudera.org:8080/11144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id347847d117509b0eadedcb4117b4e781f6e3654
Gerrit-Change-Number: 11144
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] consensus: atomicize timestamp/opid assignment
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/11144 )
Change subject: consensus: atomicize timestamp/opid assignment
......................................................................
Abandoned
went with a different approach for KUDU-2463
--
To view, visit http://gerrit.cloudera.org:8080/11144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id347847d117509b0eadedcb4117b4e781f6e3654
Gerrit-Change-Number: 11144
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
[kudu-CR] consensus: atomicize timestamp/opid assignment
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11144 )
Change subject: consensus: atomicize timestamp/opid assignment
......................................................................
Patch Set 3:
abandon?
--
To view, visit http://gerrit.cloudera.org:8080/11144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id347847d117509b0eadedcb4117b4e781f6e3654
Gerrit-Change-Number: 11144
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Fri, 12 Oct 2018 21:41:52 +0000
Gerrit-HasComments: No