You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Martin Hauner <ma...@gmx.net> on 2009/10/25 18:34:11 UTC

[PATCH] libsvn_wc (status.c) result_pool/scratch_pool

Hi,

another scratch_pool patch.

Note that there is an issue in close_directory. A result gets allocated
in the scratch_pool. I can't add a result_pool because it is a callback
implementation.

Should I do anything here?

See
http://subversion.tigris.org/ds/viewMessage.do?dsMessageId=2400681&dsForumId=462

-- 
Martin

Subcommander 2.0.0 Beta 5 - http://subcommander.tigris.org
a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411208

Re: [PATCH] libsvn_wc (status.c) result_pool/scratch_pool

Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi Martin,

Just thought I would chase up whether or not you were gong to follow-on with this patch submission and the extra information provided by Julian?
(And while I am sure you know already - you should feel at ease asking for any help that you might need.)

I only ask so that I know whether or not keep an eye on this particular thread or not.

Gavin.


On 10/11/2009, at 01:36 , Julian Foad wrote:

> Gavin Baumanis wrote:
>> I have logged issue #3520:
>> http://subversion.tigris.org/issues/show_bug.cgi?id=3520
> 
> 
>>> On 26/10/2009, at 05:34 , Martin Hauner wrote:
>>>> another scratch_pool patch.
>>>> 
>>>> Note that there is an issue in close_directory. A result gets allocated
>>>> in the scratch_pool. I can't add a result_pool because it is a callback
>>>> implementation.
>>>> 
>>>> Should I do anything here?
>>>> 
>>>> See
>>>> http://subversion.tigris.org/ds/viewMessage.do?dsMessageId=2400681&dsForumId=462
> 
> That looks like a bug in libsvn_wc/status.c:close_directory(), currently
> line 1857:
> 
>    eb->anchor_status​->ood_last_cmt_au​thor =
>      apr_pstrdup(pool, db->ood_last_cmt_author);
> 
> I don't believe it should allocate stuff in the edit baton from its
> passed-in "pool". I think we need to add a pool pointer in the edit
> baton, and initialize it to a pool that has the correct life time.
> 
> - Julian
> 
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415797

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416481

Re: [PATCH] libsvn_wc (status.c) result_pool/scratch_pool

Posted by Julian Foad <ju...@btopenworld.com>.
Gavin Baumanis wrote:
> I have logged issue #3520:
> http://subversion.tigris.org/issues/show_bug.cgi?id=3520


> > On 26/10/2009, at 05:34 , Martin Hauner wrote:
> >> another scratch_pool patch.
> >>
> >> Note that there is an issue in close_directory. A result gets allocated
> >> in the scratch_pool. I can't add a result_pool because it is a callback
> >> implementation.
> >>
> >> Should I do anything here?
> >>
> >> See
> >> http://subversion.tigris.org/ds/viewMessage.do?dsMessageId=2400681&dsForumId=462

That looks like a bug in libsvn_wc/status.c:close_directory(), currently
line 1857:

    eb->anchor_status​->ood_last_cmt_au​thor =
      apr_pstrdup(pool, db->ood_last_cmt_author);

I don't believe it should allocate stuff in the edit baton from its
passed-in "pool". I think we need to add a pool pointer in the edit
baton, and initialize it to a pool that has the correct life time.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415797

Re: [PATCH] libsvn_wc (status.c) result_pool/scratch_pool

Posted by Gavin Baumanis <ga...@thespidernet.com>.
I have logged issue #3520:
http://subversion.tigris.org/issues/show_bug.cgi?id=3520

Gavin.


On 03/11/2009, at 10:13 , Gavin Baumanis wrote:

> Ping. This email has received no comments.
>
> Gavin.
>
>
> On 26/10/2009, at 05:34 , Martin Hauner wrote:
>
>> Hi,
>>
>> another scratch_pool patch.
>>
>> Note that there is an issue in close_directory. A result gets
>> allocated
>> in the scratch_pool. I can't add a result_pool because it is a
>> callback
>> implementation.
>>
>> Should I do anything here?
>>
>> See
>> http://subversion.tigris.org/ds/viewMessage.do?dsMessageId=2400681&dsForumId=462
>>
>> -- 
>> Martin
>>
>> Subcommander 2.0.0 Beta 5 - http://subcommander.tigris.org
>> a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?
>> dsForumId=462&dsMessageId=2411208<wc_status_2.patch>
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2413971

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415371

Re: [PATCH] libsvn_wc (status.c) result_pool/scratch_pool

Posted by Gavin Baumanis <ga...@thespidernet.com>.
Ping. This email has received no comments.

Gavin.


On 26/10/2009, at 05:34 , Martin Hauner wrote:

> Hi,
>
> another scratch_pool patch.
>
> Note that there is an issue in close_directory. A result gets  
> allocated
> in the scratch_pool. I can't add a result_pool because it is a  
> callback
> implementation.
>
> Should I do anything here?
>
> See
> http://subversion.tigris.org/ds/viewMessage.do?dsMessageId=2400681&dsForumId=462
>
> -- 
> Martin
>
> Subcommander 2.0.0 Beta 5 - http://subcommander.tigris.org
> a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do? 
> dsForumId=462&dsMessageId=2411208<wc_status_2.patch>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2413971