You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by cschneider <gi...@git.apache.org> on 2015/11/30 15:04:26 UTC
[GitHub] activemq-artemis pull request: ARTEMIS-93 Add default config to fe...
GitHub user cschneider opened a pull request:
https://github.com/apache/activemq-artemis/pull/254
ARTEMIS-93 Add default config to feature
Adds default configs to the feature so a broker is created automatically when the feature is installed.
This also fixes a bug in the feature file I introduced by placing the license header in the wrong position.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cschneider/activemq-artemis OSGi
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/254.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #254
----
commit 6cb1a1c80ad17b0615a1ed68aa1071bff19ebf87
Author: Christian Schneider <ch...@die-schneider.net>
Date: 2015-11-30T14:02:04Z
ARTEMIS-93 Add default config to feature
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Ensure all references to the projec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-93 Add default config to fe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-93 Add default config to fe...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/254#issuecomment-160652674
@cschneider I always preferred on by default, we disabled it because of discussions on the dev list... someone downloading the source distribution would prefer making changes without being bound to checkstyle and other things.. so it was "decided" devs should use the dev profile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-93 Add default config to fe...
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider commented on the pull request:
https://github.com/apache/activemq-artemis/pull/254#issuecomment-160649094
Sorry.. forgot to use the profile again. I will make sure I run it from now on. Btw. The checks only seem to take 10 seconds for the whole build. Wouldn't it make sense to include them in mvn install?
In this case I excluded the org.apache.activemq.artemis.cfg from the rat check as I think it does not make sense to add a license to a 3 line cfg. Is this ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-93 Add default config to fe...
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider commented on the pull request:
https://github.com/apache/activemq-artemis/pull/254#issuecomment-160659926
Btw. I really like the Jenkins integration with the pull request. I must find out how to also support this in CXF, Aries and Karaf.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Ensure all references to the projec...
Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/254#issuecomment-101663518
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-93 Add default config to fe...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/254#issuecomment-160652950
It's ok to add ignores on the rat check for such things. yeah.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-93 Add default config to fe...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/254#issuecomment-160656945
I have no issues with the failed builds (I send failed builds myself all the time)... I was just letting you know about the -Pdev profile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-93 Add default config to fe...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/254#issuecomment-160644417
when you build, you should do:
mvn -Pdev install
That will activate checks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-93 Add default config to fe...
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider commented on the pull request:
https://github.com/apache/activemq-artemis/pull/254#issuecomment-160655548
Ok for me to build with the profile. In any case you can ignore my pull requests until jenkins likes them :-)
I will also make sure to then squash my commits into a single one so there is not to much noise in the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---