You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/07/08 05:24:44 UTC
Review Request: FLUME-1348: Docs updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5825/
-----------------------------------------------------------
Review request for Flume and Mike Percy.
Description
-------
Docs only change.
This addresses bug FLUME-1348.
https://issues.apache.org/jira/browse/FLUME-1348
Diffs
-----
flume-ng-doc/sphinx/FlumeDeveloperGuide.rst ce147c2
flume-ng-doc/sphinx/FlumeUserGuide.rst 613f3e7
flume-ng-doc/sphinx/conf.py ac823c7
flume-ng-doc/sphinx/index.rst 1749f36
Diff: https://reviews.apache.org/r/5825/diff/
Testing
-------
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1348: Docs updates.
Posted by Hari Shreedharan <hs...@cloudera.com>.
> On July 9, 2012, midnight, Mike Percy wrote:
> > flume-ng-doc/sphinx/index.rst, line 60
> > <https://reviews.apache.org/r/5825/diff/3/?file=120345#file120345line60>
> >
> > This change shouldn't be made... look inside the dist tarball under docs/ and you will see that it's correct as-is.
Ah, thanks for the catch. That was an experimental change I made, so I could verify the javadocs without playing around with the dist tarball.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5825/#review8957
-----------------------------------------------------------
On July 8, 2012, 3:29 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5825/
> -----------------------------------------------------------
>
> (Updated July 8, 2012, 3:29 a.m.)
>
>
> Review request for Flume and Mike Percy.
>
>
> Description
> -------
>
> Docs only change.
>
>
> This addresses bug FLUME-1348.
> https://issues.apache.org/jira/browse/FLUME-1348
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeDeveloperGuide.rst ce147c2
> flume-ng-doc/sphinx/FlumeUserGuide.rst 613f3e7
> flume-ng-doc/sphinx/conf.py ac823c7
> flume-ng-doc/sphinx/index.rst 1749f36
>
> Diff: https://reviews.apache.org/r/5825/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1348: Docs updates.
Posted by Mike Percy <mp...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5825/#review8957
-----------------------------------------------------------
Ship it!
+1
In the interest of time I'm going to commit this, modulo the below feedback.
flume-ng-doc/sphinx/index.rst
<https://reviews.apache.org/r/5825/#comment19044>
This change shouldn't be made... look inside the dist tarball under docs/ and you will see that it's correct as-is.
- Mike Percy
On July 8, 2012, 3:29 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5825/
> -----------------------------------------------------------
>
> (Updated July 8, 2012, 3:29 a.m.)
>
>
> Review request for Flume and Mike Percy.
>
>
> Description
> -------
>
> Docs only change.
>
>
> This addresses bug FLUME-1348.
> https://issues.apache.org/jira/browse/FLUME-1348
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeDeveloperGuide.rst ce147c2
> flume-ng-doc/sphinx/FlumeUserGuide.rst 613f3e7
> flume-ng-doc/sphinx/conf.py ac823c7
> flume-ng-doc/sphinx/index.rst 1749f36
>
> Diff: https://reviews.apache.org/r/5825/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1348: Docs updates.
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5825/#review8951
-----------------------------------------------------------
Ship it!
Looks good to me.
Jarcec
- Jarek Cecho
On July 8, 2012, 3:29 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5825/
> -----------------------------------------------------------
>
> (Updated July 8, 2012, 3:29 a.m.)
>
>
> Review request for Flume and Mike Percy.
>
>
> Description
> -------
>
> Docs only change.
>
>
> This addresses bug FLUME-1348.
> https://issues.apache.org/jira/browse/FLUME-1348
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeDeveloperGuide.rst ce147c2
> flume-ng-doc/sphinx/FlumeUserGuide.rst 613f3e7
> flume-ng-doc/sphinx/conf.py ac823c7
> flume-ng-doc/sphinx/index.rst 1749f36
>
> Diff: https://reviews.apache.org/r/5825/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1348: Docs updates.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5825/
-----------------------------------------------------------
(Updated July 8, 2012, 3:29 a.m.)
Review request for Flume and Mike Percy.
Description
-------
Docs only change.
This addresses bug FLUME-1348.
https://issues.apache.org/jira/browse/FLUME-1348
Diffs (updated)
-----
flume-ng-doc/sphinx/FlumeDeveloperGuide.rst ce147c2
flume-ng-doc/sphinx/FlumeUserGuide.rst 613f3e7
flume-ng-doc/sphinx/conf.py ac823c7
flume-ng-doc/sphinx/index.rst 1749f36
Diff: https://reviews.apache.org/r/5825/diff/
Testing
-------
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1348: Docs updates.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5825/
-----------------------------------------------------------
(Updated July 8, 2012, 3:27 a.m.)
Review request for Flume and Mike Percy.
Changes
-------
Removing trailing whitespaces.
Description
-------
Docs only change.
This addresses bug FLUME-1348.
https://issues.apache.org/jira/browse/FLUME-1348
Diffs (updated)
-----
flume-ng-doc/sphinx/FlumeDeveloperGuide.rst ce147c2
flume-ng-doc/sphinx/FlumeUserGuide.rst 613f3e7
flume-ng-doc/sphinx/conf.py ac823c7
flume-ng-doc/sphinx/index.rst 1749f36
Diff: https://reviews.apache.org/r/5825/diff/
Testing
-------
Thanks,
Hari Shreedharan