You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by ah...@apache.org on 2024/06/11 04:29:33 UTC
(causeway) branch master updated: CAUSEWAY-2297: minor: comments and JPMS warnings
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/causeway.git
The following commit(s) were added to refs/heads/master by this push:
new 2a80724907 CAUSEWAY-2297: minor: comments and JPMS warnings
2a80724907 is described below
commit 2a807249079b39a8db2fc17e54b10071e9714824
Author: Andi Huber <ah...@apache.org>
AuthorDate: Tue Jun 11 06:29:28 2024 +0200
CAUSEWAY-2297: minor: comments and JPMS warnings
---
persistence/commons/src/main/java/module-info.java | 4 ++--
.../integration/changetracking/EntityChangeTrackerDefault.java | 2 +-
.../causeway/viewer/wicket/model/models/ScalarParameterModel.java | 5 ++---
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/persistence/commons/src/main/java/module-info.java b/persistence/commons/src/main/java/module-info.java
index 8de9488e1f..e90abfdeb4 100644
--- a/persistence/commons/src/main/java/module-info.java
+++ b/persistence/commons/src/main/java/module-info.java
@@ -29,10 +29,10 @@ module org.apache.causeway.persistence.commons {
requires java.sql;
requires java.xml;
requires lombok;
- requires org.apache.causeway.applib;
+ requires transitive org.apache.causeway.applib;
requires org.apache.causeway.commons;
requires org.apache.causeway.core.config;
- requires org.apache.causeway.core.metamodel;
+ requires transitive org.apache.causeway.core.metamodel;
requires org.apache.causeway.core.runtime;
requires org.apache.causeway.core.transaction;
requires org.apache.causeway.schema;
diff --git a/persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/changetracking/EntityChangeTrackerDefault.java b/persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/changetracking/EntityChangeTrackerDefault.java
index 1d8374d302..6bf4097b31 100644
--- a/persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/changetracking/EntityChangeTrackerDefault.java
+++ b/persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/changetracking/EntityChangeTrackerDefault.java
@@ -247,7 +247,7 @@ implements
private void enableCommandPublishing() {
val alreadySet = persistentChangesEncountered.getAndSet(true);
if(!alreadySet) {
- val command = currentInteraction().getCommand();
+ currentInteraction().getCommand(); //TODO does this call have side-effects? if so explain, else remove
}
}
diff --git a/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/ScalarParameterModel.java b/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/ScalarParameterModel.java
index b83fdab3c3..837be50e96 100644
--- a/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/ScalarParameterModel.java
+++ b/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/ScalarParameterModel.java
@@ -28,8 +28,6 @@ import org.apache.causeway.core.metamodel.spec.feature.ObjectAction;
import org.apache.causeway.viewer.commons.model.scalar.HasUiParameter;
import org.apache.causeway.viewer.wicket.model.models.interaction.act.UiParameterWkt;
-import org.apache.wicket.markup.html.form.upload.FileUpload;
-
import lombok.Getter;
import lombok.NonNull;
@@ -61,7 +59,8 @@ implements HasUiParameter {
@Override
public String validate(final @NonNull ManagedObject proposedArg) {
- // workaround for FileUpload
+ //TODO[CAUSEWAY-3764] workaround for org.apache.wicket.markup.html.form.upload.FileUpload leaking into the meta-model
+ // find the root cause then clean-up
if(proposedArg.getSpecification().getBeanSort().isUnknown()) {
return null;
}