You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2013/11/12 06:02:04 UTC
Review Request 15446: [HELIX-299] Some files in 0.6.2 are missing license
headers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15446/
-----------------------------------------------------------
Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
Bugs: HELIX-299
Repository: helix-git
Description
-------
commit 2677b40b067feb3290dfb57959d590f8220b4972
Author: Kanak Biscuitwala <ka...@hotmail.com>
Date: Mon Nov 11 21:01:08 2013 -0800
[HELIX-299] Some files in 0.6.2 are missing license headers
:100644 100644 f91bf71... 7ada7c8... M helix-core/src/main/java/org/apache/helix/manager/zk/HelixManagerShutdownHook.java
:100644 100644 b72170f... c483fbb... M helix-core/src/main/java/org/apache/helix/tools/ClusterExternalViewVerifier.java
:100644 100644 2912247... b9de466... M helix-core/src/main/java/org/apache/helix/tools/ClusterLiveNodesVerifier.java
:100644 100644 ca8eea7... 98757c1... M helix-core/src/main/java/org/apache/helix/tools/ClusterVerifier.java
:100644 100644 8c70bbc... ff23a16... M helix-core/src/main/java/org/apache/helix/tools/IntegrationTestUtil.java
:100644 100644 37709fc... 370ee05... M helix-core/src/test/java/org/apache/helix/manager/zk/TestZkFlapping.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/manager/zk/HelixManagerShutdownHook.java f91bf71
helix-core/src/main/java/org/apache/helix/tools/ClusterExternalViewVerifier.java b72170f
helix-core/src/main/java/org/apache/helix/tools/ClusterLiveNodesVerifier.java 2912247
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifier.java ca8eea7
helix-core/src/main/java/org/apache/helix/tools/IntegrationTestUtil.java 8c70bbc
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkFlapping.java 37709fc
Diff: https://reviews.apache.org/r/15446/diff/
Testing
-------
rat plugin passes
Thanks,
Kanak Biscuitwala
Re: Review Request 15446: [HELIX-299] Some files in 0.6.2 are missing
license headers
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15446/#review28723
-----------------------------------------------------------
Ship it!
Ship It!
- Zhen Zhang
On Nov. 12, 2013, 5:02 a.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15446/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2013, 5:02 a.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-299
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit 2677b40b067feb3290dfb57959d590f8220b4972
> Author: Kanak Biscuitwala <ka...@hotmail.com>
> Date: Mon Nov 11 21:01:08 2013 -0800
>
> [HELIX-299] Some files in 0.6.2 are missing license headers
>
> :100644 100644 f91bf71... 7ada7c8... M helix-core/src/main/java/org/apache/helix/manager/zk/HelixManagerShutdownHook.java
> :100644 100644 b72170f... c483fbb... M helix-core/src/main/java/org/apache/helix/tools/ClusterExternalViewVerifier.java
> :100644 100644 2912247... b9de466... M helix-core/src/main/java/org/apache/helix/tools/ClusterLiveNodesVerifier.java
> :100644 100644 ca8eea7... 98757c1... M helix-core/src/main/java/org/apache/helix/tools/ClusterVerifier.java
> :100644 100644 8c70bbc... ff23a16... M helix-core/src/main/java/org/apache/helix/tools/IntegrationTestUtil.java
> :100644 100644 37709fc... 370ee05... M helix-core/src/test/java/org/apache/helix/manager/zk/TestZkFlapping.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/manager/zk/HelixManagerShutdownHook.java f91bf71
> helix-core/src/main/java/org/apache/helix/tools/ClusterExternalViewVerifier.java b72170f
> helix-core/src/main/java/org/apache/helix/tools/ClusterLiveNodesVerifier.java 2912247
> helix-core/src/main/java/org/apache/helix/tools/ClusterVerifier.java ca8eea7
> helix-core/src/main/java/org/apache/helix/tools/IntegrationTestUtil.java 8c70bbc
> helix-core/src/test/java/org/apache/helix/manager/zk/TestZkFlapping.java 37709fc
>
> Diff: https://reviews.apache.org/r/15446/diff/
>
>
> Testing
> -------
>
> rat plugin passes
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>