You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/21 02:46:57 UTC

[GitHub] [incubator-shardingsphere] nancyzrh opened a new pull request #4059: optimize test

nancyzrh opened a new pull request #4059: optimize test
URL: https://github.com/apache/incubator-shardingsphere/pull/4059
 
 
   for #3317 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4059: optimize test

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4059: optimize test
URL: https://github.com/apache/incubator-shardingsphere/pull/4059#discussion_r368987464
 
 

 ##########
 File path: sharding-integration-test/sharding-jdbc-test/src/test/java/org/apache/shardingsphere/dbtest/engine/util/IntegrateTestParameters.java
 ##########
 @@ -67,7 +68,8 @@
             SQLCaseType caseType = (SQLCaseType) each[2];
             Class<?> sqlStatementClass = SQLParseEngineFactory.getSQLParseEngine(
                     DatabaseTypes.getTrunkDatabaseType(databaseType).getName()).parse(sqlCasesLoader.getSQL(sqlCaseId, SQLCaseType.Placeholder, Collections.emptyList()), false).getClass();
-            if (!sqlType.getSqlStatementClass().isAssignableFrom(sqlStatementClass)) {
+            if (!sqlType.getSqlStatementClass().isAssignableFrom(sqlStatementClass)
 
 Review comment:
   The code `SQLType.DML == sqlType && SelectStatement.class == sqlStatementClass` is difficult to understand.
   We need consider about it or add some comment to let develop know what happen

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4059: optimize test

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4059: optimize test
URL: https://github.com/apache/incubator-shardingsphere/pull/4059#issuecomment-579615739
 
 
   Closed because we change the default branch from dev to master.
   Please re-summit pr to master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4059: optimize test

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4059: optimize test
URL: https://github.com/apache/incubator-shardingsphere/pull/4059#issuecomment-576544530
 
 
   ## Pull Request Test Coverage Report for [Build 1463](https://coveralls.io/builds/28224989)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **6** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.008%**) to **66.882%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/dql/EncryptMergedResult.java](https://coveralls.io/builds/28224989/source?filename=encrypt-core%2Fencrypt-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2Fdql%2FEncryptMergedResult.java#L53) | 6 | 0% |
   <!-- | **Total:** | **6** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28224989/badge)](https://coveralls.io/builds/28224989) |
   | :-- | --: |
   | Change from base [Build 722](https://coveralls.io/builds/28221581): |  -0.008% |
   | Covered Lines: | 10895 |
   | Relevant Lines: | 16290 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] nancyzrh commented on issue #4059: optimize test

Posted by GitBox <gi...@apache.org>.
nancyzrh commented on issue #4059: optimize test
URL: https://github.com/apache/incubator-shardingsphere/pull/4059#issuecomment-576503253
 
 
   /run ci

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] nancyzrh commented on issue #4059: optimize test

Posted by GitBox <gi...@apache.org>.
nancyzrh commented on issue #4059: optimize test
URL: https://github.com/apache/incubator-shardingsphere/pull/4059#issuecomment-576502987
 
 
   /run ci

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu closed pull request #4059: optimize test

Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #4059: optimize test
URL: https://github.com/apache/incubator-shardingsphere/pull/4059
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] nancyzrh commented on issue #4059: optimize test

Posted by GitBox <gi...@apache.org>.
nancyzrh commented on issue #4059: optimize test
URL: https://github.com/apache/incubator-shardingsphere/pull/4059#issuecomment-576537503
 
 
   /run ci

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] nancyzrh commented on issue #4059: optimize test

Posted by GitBox <gi...@apache.org>.
nancyzrh commented on issue #4059: optimize test
URL: https://github.com/apache/incubator-shardingsphere/pull/4059#issuecomment-576496029
 
 
   /run ci

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] nancyzrh commented on issue #4059: optimize test

Posted by GitBox <gi...@apache.org>.
nancyzrh commented on issue #4059: optimize test
URL: https://github.com/apache/incubator-shardingsphere/pull/4059#issuecomment-576495596
 
 
   /run ci

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] nancyzrh commented on issue #4059: optimize test

Posted by GitBox <gi...@apache.org>.
nancyzrh commented on issue #4059: optimize test
URL: https://github.com/apache/incubator-shardingsphere/pull/4059#issuecomment-576505370
 
 
   /run ci

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services