You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/15 03:35:27 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #28536: [WIP][SPARK-XXX][SQL] Use a fallback version in HiveExternalCatalogVersionsSuite
dongjoon-hyun opened a new pull request #28536:
URL: https://github.com/apache/spark/pull/28536
…
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629068684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28536: [WIP][SPARK-XXX][SQL] Use a fallback version in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629009343
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629065007
The real download is okay. As you see on the result, the download logic have a fallback logic. The network issue happens differently on the URL, @viirya and @cloud-fan .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629065007
The real download is okay. As you see on the result, the download logic have a fallback logic. The network issue happens differently on the URL, @viirya and @cloud-fan .
For example, gitbox.apache.org failed while github.com succeeded. Please see SPARK-31693~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629591207
Thank you, @HyukjinKwon .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629069033
If you don't mind, I'll merge this to master/3.0/2.4 to recover them. Currently, this is a blocker for all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629590253
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28536: [WIP][SPARK-XXX][SQL] Use a fallback version in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629007660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629056740
same question with @viirya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28536: [WIP][SPARK-XXX][SQL] Use a fallback version in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629009343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629069033
If you don't mind, I'll merge this to master/3.0/2.4 to recover them. Currently, this is a blocker for all. Current situation is a kind of disaster.
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629069242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629066791
Both jenkins test jobs are running on R test stage, but they will fail soon since it's PST midnight.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28536:
URL: https://github.com/apache/spark/pull/28536#discussion_r426119828
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
##########
@@ -242,7 +242,7 @@ object PROCESS_TABLES extends QueryTest with SQLTestUtils {
.filter(_ < org.apache.spark.SPARK_VERSION)
} catch {
// do not throw exception during object initialization.
- case NonFatal(_) => Nil
+ case NonFatal(_) => Seq("2.3.4", "2.4.5") // A temporary fallback to use a specific version
Review comment:
Ah, okay. Just read about SPARK-31717.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629067994
BTW, there was several blockers until now. I believe this will recover most jobs. `master` branch Hadoop 3.2 profile jobs are failing on suspicious YARN patches. I also pinged on that commit, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629009075
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28536: [WIP][SPARK-XXX][SQL] Use a fallback version in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629007295
**[Test build #122643 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122643/testReport)** for PR 28536 at commit [`6d44e9e`](https://github.com/apache/spark/commit/6d44e9e1e216a9135ab3e823358cc7d05788f33c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629065007
The real download is okay. As you see the Jenkins running status, the download logic have a fallback logic (try some mirror and go to `https://archive.apache.org/dist`). The URLs are different and the network issue happens differently on the URL, @viirya and @cloud-fan .
For example, gitbox.apache.org failed while github.com succeeded. Please see SPARK-31693~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28536: [WIP][SPARK-XXX][SQL] Use a fallback version in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629009075
**[Test build #122644 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122644/testReport)** for PR 28536 at commit [`5505ab1`](https://github.com/apache/spark/commit/5505ab1c0d7890750f4a5bd4888befb4154450d6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28536: [SPARK-31716][SQL] Use a fallback version in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629044913
Hi, @cloud-fan and @HyukjinKwon .
Could you review this PR? This PR is providing a fallback Spark versions instead of failing. AFAIK, this is the only way to recover our Jenkins jobs without losing the test coverage. I filed SPARK-31717 together to revert or replace this ad-hoc later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629069242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28536: [WIP][SPARK-XXX][SQL] Use a fallback version in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629009346
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27306/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629065007
The real download is okay. As you see on the result, the download logic have a fallback logic (try some mirror and go to `https://archive.apache.org/dist`). The URLs are different and the network issue happens differently on the URL, @viirya and @cloud-fan .
For example, gitbox.apache.org failed while github.com succeeded. Please see SPARK-31693~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629078685
Merged to master/3.0/2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629065007
As you see on the result, the download logic have a fallback logic. The network issue happens differently, @viirya and @cloud-fan .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28536:
URL: https://github.com/apache/spark/pull/28536#discussion_r426119773
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
##########
@@ -242,7 +242,7 @@ object PROCESS_TABLES extends QueryTest with SQLTestUtils {
.filter(_ < org.apache.spark.SPARK_VERSION)
} catch {
// do not throw exception during object initialization.
- case NonFatal(_) => Nil
+ case NonFatal(_) => Seq("2.3.4", "2.4.5") // A temporary fallback to use a specific version
Review comment:
@dongjoon-hyun, is it a temporary fix? If we want to keep this, looks like we don't need to try to have this list above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28536: [WIP][SPARK-XXX][SQL] Use a fallback version in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28536:
URL: https://github.com/apache/spark/pull/28536#issuecomment-629007660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28536:
URL: https://github.com/apache/spark/pull/28536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org