[GitHub] paul-rogers commented on a change in pull request #1599: DRILL-6903: SchemaBuilder code improvements

[GitBox <gi...@apache.org>]

paul-rogers commented on a change in pull request #1599: DRILL-6903: SchemaBuilder code improvements
URL: https://github.com/apache/drill/pull/1599#discussion_r245887831
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/metadata/MapBuilder.java
 ##########
 @@ -123,30 +126,36 @@ public RepeatedListBuilder addRepeatedList(String name) {
     return tupleBuilder.addRepeatedList(this, name);
   }
 
-  private MapColumnMetadata buildCol() {
+  public MapColumnMetadata buildColumn() {
 
 Review comment:
   This was private because only the top-level schema builder was meant to be public. These intermediate items are used internally to create a map in the middle of building a schema.
   
   Might well work by itself, just didn't test it that way. Looks like you've made the parent optional, which might be OK.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services