You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ch...@apache.org on 2017/07/31 11:59:16 UTC

[09/12] flink git commit: [hotfix] [tests] fix JobRetrievalITCase#testJobRetrieval() test job not running

[hotfix] [tests] fix JobRetrievalITCase#testJobRetrieval() test job not running

Although this test should only verify that ClusterClient#retrieveJob() is
working, the inability to run the invokable given to the job does at least print
an exception in the test output that may be confusing.

This closes #4417.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/738dbbe5
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/738dbbe5
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/738dbbe5

Branch: refs/heads/master
Commit: 738dbbe57b1476f4d24ba8863d021ece11a6f514
Parents: a4a4e0b
Author: Nico Kruber <ni...@data-artisans.com>
Authored: Fri Jul 28 14:16:10 2017 +0200
Committer: zentol <ch...@apache.org>
Committed: Mon Jul 31 12:12:09 2017 +0200

----------------------------------------------------------------------
 .../apache/flink/test/example/client/JobRetrievalITCase.java  | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/738dbbe5/flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
----------------------------------------------------------------------
diff --git a/flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java b/flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
index 6ce4f76..39eeccb 100644
--- a/flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
+++ b/flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
@@ -132,7 +132,12 @@ public class JobRetrievalITCase extends TestLogger {
 		}
 	}
 
-	private static class SemaphoreInvokable extends AbstractInvokable {
+	/**
+	 * Invokable that waits on {@link #lock} to be released and finishes afterwards.
+	 *
+	 * <p>NOTE: needs to be <tt>public</tt> so that a task can be run with this!
+	 */
+	public static class SemaphoreInvokable extends AbstractInvokable {
 
 		@Override
 		public void invoke() throws Exception {