You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/22 00:08:50 UTC

[GitHub] [beam] lostluck commented on pull request #17370: [BEAM-14306] Add unit testing to pane coder

lostluck commented on PR #17370:
URL: https://github.com/apache/beam/pull/17370#issuecomment-1105871922

   The only thing I can think of to improve things is to include hard coded values for the encoded/decoded panes,  (eg the "no firing pane" is `0xf`) etc, so we aren't relying on the round trip for correctness.  (eg. If I say A(B(0)) = 0, all that says is A and B are inverses, but not what they do.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org