You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Sean-Kenneth-Doherty (via GitHub)" <gi...@apache.org> on 2026/05/17 08:29:35 UTC
[PR] Guard runtime SET UTF-8 suffix parsing [datafusion]
Sean-Kenneth-Doherty opened a new pull request, #22301:
URL: https://github.com/apache/datafusion/pull/22301
## What changed
- Avoid byte-index slicing when runtime `SET` parsing separates the numeric value from its unit suffix.
- Reuse a UTF-8-safe helper for memory limits, capacity limits, and duration segments.
- Add parser-level and public SQL-path regression coverage for non-ASCII suffix values.
Fixes #22187.
## Validation
- `cargo fmt --check --all`
- `git diff --check origin/main...HEAD`
- `cargo test -p datafusion --lib test_parse_`
- `cargo test -p datafusion --test core_integration test_runtime_config_non_ascii_suffix_returns_error`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Guard runtime SET UTF-8 suffix parsing [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on code in PR #22301:
URL: https://github.com/apache/datafusion/pull/22301#discussion_r3270942467
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -305,6 +305,11 @@ impl Default for SessionContext {
}
impl SessionContext {
+ fn split_number_and_unit(value: &str) -> (&str, &str) {
Review Comment:
Can probably move this out of the impl here since does really relate to `SessionContext`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Guard runtime SET UTF-8 suffix parsing [datafusion]
Posted by "Sean-Kenneth-Doherty (via GitHub)" <gi...@apache.org>.
Sean-Kenneth-Doherty commented on PR #22301:
URL: https://github.com/apache/datafusion/pull/22301#issuecomment-4469969037
Validated head df3afaa0804ca019303be24a6056448999afb111 locally. The patch targets the old byte-index slicing path, and the regression now returns normal planning errors for non-ASCII suffixes instead of panicking.
Commands run:
- `cargo fmt --check --all`
- `git diff --check origin/main...HEAD`
- `git diff --check`
- `cargo test -p datafusion --lib test_parse_` (4 passed)
- `cargo test -p datafusion --test core_integration test_runtime_config_non_ascii_suffix_returns_error` (1 passed)
- `cargo test -p datafusion --test core_integration runtime_config` (12 passed)
Working tree remained clean after validation. Hosted checks currently show the labeler `Process` check passing; no broader CI jobs have been scheduled on the PR yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org