[jira] [Commented] (SLING-10860) ServerErrorRetryStrategy should not retry if the code is expected

["Thierry Ygé (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426053#comment-17426053 ] 

Thierry Ygé commented on SLING-10860:
-------------------------------------

Note I have prepared a PR on [https://github.com/apache/sling-org-apache-sling-testing-clients/pull/23]

I have added a test, and fixed 2, which I believe was actually originally pointing the issue or at least didn't test I believe the expectation, meaning that it would do number of tries and throw actually an exception.

 

> ServerErrorRetryStrategy should not retry if the code is expected
> -----------------------------------------------------------------
>
>                 Key: SLING-10860
>                 URL: https://issues.apache.org/jira/browse/SLING-10860
>             Project: Sling
>          Issue Type: Bug
>          Components: Apache Sling Testing Clients
>    Affects Versions: Apache Sling Testing Clients 2.0.10
>            Reporter: Thierry Ygé
>            Priority: Major
>
> Currently the ServerErrorRetryStrategy would retry for the list of error codes or if not defined default for 500 and above.
> Let say you have a a test that expect a 500 or any other code define in the list of error codes.
> client.doGet("someurl", 500);
> That will then retry a number of time, while in fact this code is expected to happen, so in that case it should not retry.
> Since we have control on the "http" context parameter, the expected status codes could be passed in that object , and so used to decide or not if we need a retry too.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)