[GitHub] [druid] aP0StAl commented on a change in pull request #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

[GitBox <gi...@apache.org>]

aP0StAl commented on a change in pull request #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder
URL: https://github.com/apache/druid/pull/9568#discussion_r399471444
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/aggregation/mean/DoubleMeanAggregatorFactory.java
 ##########
 @@ -152,6 +152,8 @@ public Object deserialize(Object object)
       return DoubleMeanHolder.fromBytes(StringUtils.decodeBase64(StringUtils.toUtf8((String) object)));
     } else if (object instanceof DoubleMeanHolder) {
       return object;
+    } else if (object instanceof byte[]) {
 
 Review comment:
   But DoubleMeanHolder in both places too. Maybe we will replace only String in deserialize(..)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org