You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/14 08:31:38 UTC
[GitHub] [incubator-nuttx] takumiando opened a new issue, #7089: How to use multiple RTC drivers?
takumiando opened a new issue, #7089:
URL: https://github.com/apache/incubator-nuttx/issues/7089
Does not NuttX support multiple RTCs?
I want to use the internal and external RTCs, but the definitions of functions conflicts each other at building.
```
/path/to/nuttx/arch/arm/src/chip/cxd56_rtc.c:433: multiple definition of `up_rtc_settime'; /path/to/nuttx/staging/libdrivers.a(ds3231.o):/path/to//nuttx/drivers/timers/ds3231.c:387: first defined here
```
Can I specify that which I use at any timings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] How to use multiple RTC drivers? [nuttx]
Posted by "takumiando (via GitHub)" <gi...@apache.org>.
takumiando closed issue #7089: How to use multiple RTC drivers?
URL: https://github.com/apache/nuttx/issues/7089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on issue #7089: How to use multiple RTC drivers?
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #7089:
URL: https://github.com/apache/incubator-nuttx/issues/7089#issuecomment-1246763948
@takumiando
Could you tell us your intention to use multiple RTCs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #7089: How to use multiple RTC drivers?
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #7089:
URL: https://github.com/apache/incubator-nuttx/issues/7089#issuecomment-1246973148
So you don't have two RTC hardware at the same time, but want to hook the different RTC hardware to up_rtc_xxx at runtime. One approach is:
1. Implement two RTC drivers by follow https://github.com/apache/incubator-nuttx/blob/master/include/nuttx/timers/rtc.h
2. Let arch_rtc.c implement up_xxx for you by call up_rtc_set_lowerhalf:
https://github.com/apache/incubator-nuttx/blob/master/include/nuttx/timers/arch_rtc.h#L45
In step 2, you check which RTC hardware exist and pass the different rtc_lowerhalf_s instance to up_rtc_set_lowerhalf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] takumiando commented on issue #7089: How to use multiple RTC drivers?
Posted by GitBox <gi...@apache.org>.
takumiando commented on issue #7089:
URL: https://github.com/apache/incubator-nuttx/issues/7089#issuecomment-1246781770
@masayuki2009
I(actually our team) develop two editions of the IoT devices(same SoC) running NuttX.
The version A uses internal RTC and the version B should use external one.
But I don't want to release two firmware binaries for each editions(for costs!).
So I want to switch RTCs in a same firmware by EEPROM, status of GPIO, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on issue #7089: How to use multiple RTC drivers?
Posted by GitBox <gi...@apache.org>.
acassis commented on issue #7089:
URL: https://github.com/apache/incubator-nuttx/issues/7089#issuecomment-1246603177
@masayuki2009 @jerpelea any idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #7089: How to use multiple RTC drivers?
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #7089:
URL: https://github.com/apache/incubator-nuttx/issues/7089#issuecomment-1247602987
> @xiaoxiang781216
>
> Thank you, I will try them!
>
> By the way,
>
> * Why do lower-half drivers depend on `up_rtc_xxx()` implementations in `Make.defs`?
arch_rtc.c is introduced very later. Before that, all RTC driver need not only implement rtc_lowerhalf_s, but also up_rtc_xxx.
> We cannot enable only lower-half in current codes.
> * Why are NOT lower-half drivers for external RTCs(under `/drivers/timers/`) implemented?
> What is difference between internals and externals?
>
> I don't understand these policies...
Since internal RTC is part of SoC, which code should put into arch/xxx/yyy/.
External RTC connected to SoC through I2C/1wire/SPI, which code should put into drivers/timer/.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] takumiando commented on issue #7089: How to use multiple RTC drivers?
Posted by GitBox <gi...@apache.org>.
takumiando commented on issue #7089:
URL: https://github.com/apache/incubator-nuttx/issues/7089#issuecomment-1247610199
>arch_rtc.c is introduced very later. Before that, all RTC driver need not only implement rtc_lowerhalf_s, but also up_rtc_xxx.
So, lower-half drivers for external RTCs(under ```/drivers/timers/```) are JUST NOT implemented yet, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #7089: How to use multiple RTC drivers?
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #7089:
URL: https://github.com/apache/incubator-nuttx/issues/7089#issuecomment-1246619230
From the arch perspective, yes you can just have one RTC hook up_rtc_xxx api. But you can expose multiple RTC through /dev/rtcx by: https://github.com/apache/incubator-nuttx/blob/master/include/nuttx/timers/rtc.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] takumiando commented on issue #7089: How to use multiple RTC drivers?
Posted by GitBox <gi...@apache.org>.
takumiando commented on issue #7089:
URL: https://github.com/apache/incubator-nuttx/issues/7089#issuecomment-1247577345
@xiaoxiang781216
Thank you, I will try them!
By the way,
- Why do lower-half drivers depend on ```up_rtc_xxx()``` implementations in ```Make.defs```?
We cannot enable only lower-half in current codes.
- Why are NOT lower-half drivers for external RTCs(under ```/drivers/timers/```) implemented?
What is difference between internals and externals?
I don't understand these policies...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #7089: How to use multiple RTC drivers?
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #7089:
URL: https://github.com/apache/incubator-nuttx/issues/7089#issuecomment-1247514988
> @xiaoxiang781216
>
> Thank you for your kind explanation! I understand your idea.
>
> But many internal RTC lower-half drivers are enabled with each `up_rtc_xxx()` implementations at the same time.
>
> For example: `/arch/arm/src/stm32/Make.defs`
>
> ```
> ifeq ($(CONFIG_STM32_RTC),y)
> CHIP_CSRCS += stm32_rtc.c
> ifeq ($(CONFIG_RTC_ALARM),y)
> CHIP_CSRCS += stm32_exti_alarm.c
> endif
> ifeq ($(CONFIG_RTC_PERIODIC),y)
> CHIP_CSRCS += stm32_exti_wakeup.c
> endif
> ifeq ($(CONFIG_RTC_DRIVER),y)
> CHIP_CSRCS += stm32_rtc_lowerhalf.c
> endif
> endif
> ```
>
> In this case, I think that `stm32_rtc.c`(`up_rtc_xxx()` implementations) and `arch_rtc.c` conflict because of same function names.
>
> Should I modify each `Make.defs` to build only lower-half drivers and `arch_rtc.c`?
Yes, you can:
1. Enable CONFIG_RTC_DRIVER but disable CONFIG_STM32_RTC to include stm32 lower-half driver only
2. Enable your external RTC driver
3. Enable arch_rtc driver
4. Check which hardware exist in your board file, and pass the exist instance to up_rtc_set_lowerhalf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] takumiando commented on issue #7089: How to use multiple RTC drivers?
Posted by GitBox <gi...@apache.org>.
takumiando commented on issue #7089:
URL: https://github.com/apache/incubator-nuttx/issues/7089#issuecomment-1247459240
@xiaoxiang781216
Thank you for your kind explanation!
I understand your idea.
But many internal RTC lower-half drivers are enabled with each ```up_rtc_xxx()``` implementations at the same time.
For example: ```/arch/arm/src/stm32/Make.defs```
```
ifeq ($(CONFIG_STM32_RTC),y)
CHIP_CSRCS += stm32_rtc.c
ifeq ($(CONFIG_RTC_ALARM),y)
CHIP_CSRCS += stm32_exti_alarm.c
endif
ifeq ($(CONFIG_RTC_PERIODIC),y)
CHIP_CSRCS += stm32_exti_wakeup.c
endif
ifeq ($(CONFIG_RTC_DRIVER),y)
CHIP_CSRCS += stm32_rtc_lowerhalf.c
endif
endif
```
In this case, I think that ```stm32_rtc.c```(```up_rtc_xxx()``` implementations) and ```arch_rtc.c``` are conflicts because of same function names.
Should I modify each ```Make.defs``` to build only lower-half drivers and ```arch_rtc.c```?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org