You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2019/10/01 16:03:17 UTC

[kudu-CR] KUDU-1938 Add range partition support pt 6 

Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14333


Change subject: KUDU-1938 Add range partition support pt 6
......................................................................

KUDU-1938 Add range partition support pt 6

Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
---
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
3 files changed, 66 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/14333/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>

[kudu-CR] KUDU-1938 Add range partition support pt 6

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14333 )

Change subject: KUDU-1938 Add range partition support pt 6
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Is this all that is needed to allow for VARCHAR to be used in partition keys? If so, could you prove it with end-to-end C++ and Java tests?

it seems it is, I just ran the tests on Impala that creates range partitions on it (which is how I noticed it didn't work). I didn't see any end-to-end tests for other types, thought testing it in partition-test.cc would be enough. I'll add end-to-end tests to this commit, pushing it now without them as I just finished rebasing the other commits.

> 
> I pushed http://gerrit.cloudera.org:8080/14335 for the (unrelated) test failure.

Thanks


-- 
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Oct 2019 19:42:59 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 Add range partition support pt 6

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14333

to look at the new patch set (#10).

Change subject: KUDU-1938 Add range partition support pt 6
......................................................................

KUDU-1938 Add range partition support pt 6

Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
---
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/integration-tests/varchar-itest.cc
4 files changed, 125 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/14333/10
-- 
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1938 Add range partition support pt 6

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14333 )

Change subject: KUDU-1938 Add range partition support pt 6
......................................................................


Patch Set 11: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Oct 2019 16:21:00 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 Add range partition support pt 6

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14333 )

Change subject: KUDU-1938 Add range partition support pt 6
......................................................................


Patch Set 8:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > Is this all that is needed to allow for VARCHAR to be used in partition keys? If so, could you prove it with end-to-end C++ and Java tests?
> 
> it seems it is, I just ran the tests on Impala that creates range partitions on it (which is how I noticed it didn't work). I didn't see any end-to-end tests for other types, thought testing it in partition-test.cc would be enough. I'll add end-to-end tests to this commit, pushing it now without them as I just finished rebasing the other commits.

Added a new end-to-end C++ test and turns out it was already tested in https://gerrit.cloudera.org/c/14050/23/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java#426
getBasicCreateTableOptions() sets a range partition on "key" which is VARCHAR in this case.


-- 
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Oct 2019 12:35:28 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 Add range partition support pt 6

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14333 )

Change subject: KUDU-1938 Add range partition support pt 6
......................................................................


Patch Set 1:

Is this all that is needed to allow for VARCHAR to be used in partition keys? If so, could you prove it with end-to-end C++ and Java tests?

I pushed http://gerrit.cloudera.org:8080/14335 for the (unrelated) test failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Oct 2019 19:19:10 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 Add range partition support pt 6

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14333 )

Change subject: KUDU-1938 Add range partition support pt 6
......................................................................


Patch Set 8: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Oct 2019 16:45:03 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 Add range partition support pt 6

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14333 )

Change subject: KUDU-1938 Add range partition support pt 6
......................................................................


Patch Set 9: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Oct 2019 16:58:13 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 Add range partition support pt 6

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14333 )

Change subject: KUDU-1938 Add range partition support pt 6
......................................................................


Patch Set 12: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 12
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Oct 2019 23:17:15 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 Add range partition support pt 6

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14333 )

Change subject: KUDU-1938 Add range partition support pt 6
......................................................................


Patch Set 7: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Oct 2019 14:02:42 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 Add range partition support pt 6

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14333

to look at the new patch set (#8).

Change subject: KUDU-1938 Add range partition support pt 6
......................................................................

KUDU-1938 Add range partition support pt 6

Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
---
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/integration-tests/varchar-itest.cc
4 files changed, 125 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/14333/8
-- 
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1938 Add range partition support pt 6

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14333 )

Change subject: KUDU-1938 Add range partition support pt 6
......................................................................


Patch Set 11: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Oct 2019 17:02:08 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 Add range partition support pt 6

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14333 )

Change subject: KUDU-1938 Add range partition support pt 6
......................................................................

KUDU-1938 Add range partition support pt 6

Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Reviewed-on: http://gerrit.cloudera.org:8080/14333
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/integration-tests/varchar-itest.cc
4 files changed, 125 insertions(+), 3 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c
Gerrit-Change-Number: 14333
Gerrit-PatchSet: 13
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)