You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/18 05:04:20 UTC
[GitHub] [spark] Peng-Lei opened a new pull request #34309: [SPARK-35925][SQL] Support DayTimeIntervalType in width-bucket function
Peng-Lei opened a new pull request #34309:
URL: https://github.com/apache/spark/pull/34309
### What changes were proposed in this pull request?
Add support DayTimeIntervalType for width_bucket function.
### Why are the changes needed?
[SPARK-35925](https://issues.apache.org/jira/browse/SPARK-35925)
1. The `WIDTH_BUCKET` function assigns values to buckets (individual segments) in an equiwidth histogram.
2. DayTimeIntervalType is necessary as an input data type for `WIDTH_BUCKET`
### Does this PR introduce _any_ user-facing change?
Yes. The user can use `width_bucket` with DayTimeIntervalType.
### How was this patch tested?
Add ut test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34309: [SPARK-35925][SQL] Support DayTimeIntervalType in width-bucket function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34309:
URL: https://github.com/apache/spark/pull/34309#issuecomment-945444899
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48828/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34309: [SPARK-35925][SQL] Support DayTimeIntervalType in width-bucket function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34309:
URL: https://github.com/apache/spark/pull/34309#issuecomment-945379151
**[Test build #144350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144350/testReport)** for PR 34309 at commit [`d329269`](https://github.com/apache/spark/commit/d3292690d74a790ac0e0aef754d6d1af5a283fbd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #34309: [SPARK-35925][SQL] Support DayTimeIntervalType in width-bucket function
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #34309:
URL: https://github.com/apache/spark/pull/34309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34309: [SPARK-35925][SQL] Support DayTimeIntervalType in width-bucket function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34309:
URL: https://github.com/apache/spark/pull/34309#issuecomment-945624153
**[Test build #144350 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144350/testReport)** for PR 34309 at commit [`d329269`](https://github.com/apache/spark/commit/d3292690d74a790ac0e0aef754d6d1af5a283fbd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34309: [SPARK-35925][SQL] Support DayTimeIntervalType in width-bucket function
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34309:
URL: https://github.com/apache/spark/pull/34309#issuecomment-945729534
+1, LGTM. Merging to master.
Thank you, @Peng-Lei .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Peng-Lei commented on pull request #34309: [SPARK-35925][SQL] Support DayTimeIntervalType in width-bucket function
Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on pull request #34309:
URL: https://github.com/apache/spark/pull/34309#issuecomment-945400915
@MaxGekk Could you take a look? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34309: [SPARK-35925][SQL] Support DayTimeIntervalType in width-bucket function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34309:
URL: https://github.com/apache/spark/pull/34309#issuecomment-945444899
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48828/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34309: [SPARK-35925][SQL] Support DayTimeIntervalType in width-bucket function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34309:
URL: https://github.com/apache/spark/pull/34309#issuecomment-945401768
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48828/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34309: [SPARK-35925][SQL] Support DayTimeIntervalType in width-bucket function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34309:
URL: https://github.com/apache/spark/pull/34309#issuecomment-945434399
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48828/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34309: [SPARK-35925][SQL] Support DayTimeIntervalType in width-bucket function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34309:
URL: https://github.com/apache/spark/pull/34309#issuecomment-945630945
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144350/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34309: [SPARK-35925][SQL] Support DayTimeIntervalType in width-bucket function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34309:
URL: https://github.com/apache/spark/pull/34309#issuecomment-945630945
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144350/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34309: [SPARK-35925][SQL] Support DayTimeIntervalType in width-bucket function
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34309:
URL: https://github.com/apache/spark/pull/34309#issuecomment-945379151
**[Test build #144350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144350/testReport)** for PR 34309 at commit [`d329269`](https://github.com/apache/spark/commit/d3292690d74a790ac0e0aef754d6d1af5a283fbd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org