You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zentol (via GitHub)" <gi...@apache.org> on 2023/05/10 13:51:27 UTC
[GitHub] [flink-connector-aws] zentol commented on a diff in pull request #49: [FLINK-24438] Add Kinesis connector using FLIP-27
zentol commented on code in PR #49:
URL: https://github.com/apache/flink-connector-aws/pull/49#discussion_r1189925470
##########
flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/enumerator/assigner/HashShardAssigner.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.source.enumerator.assigner;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.connector.kinesis.source.enumerator.KinesisShardAssigner;
+import org.apache.flink.connector.kinesis.source.split.KinesisShardSplit;
+import org.apache.flink.util.Preconditions;
+
+/** An implementation of the {@link KinesisShardAssigner} that assigns splits by hashcode. */
+@Experimental
Review Comment:
Consider not exposing these implementations directly, but hide them behind a factory method that only returns a `KinesisShardAssigner`.
##########
flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/config/SourceConfigConstants.java:
##########
@@ -0,0 +1,371 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.source.config;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.connector.aws.config.AWSConfigConstants;
+import org.apache.flink.connector.kinesis.source.reader.PollingKinesisShardSplitReader;
+
+import java.time.Duration;
+
+/** Constants to be used with the KinesisStreamsSource. */
+@Experimental
+public class SourceConfigConstants extends AWSConfigConstants {
+ /** Marks the initial position to use when reading from the Kinesis stream. */
+ public enum InitialPosition {
+ LATEST,
+ TRIM_HORIZON,
+ AT_TIMESTAMP
+ }
+
+ /** The record publisher type represents the record-consume style. */
+ public enum RecordPublisherType {
+
+ /** Consume the Kinesis records using AWS SDK v2 with the enhanced fan-out consumer. */
+ EFO,
+ /** Consume the Kinesis records using AWS SDK v1 with the get-records method. */
+ POLLING
+ }
+
+ /** The EFO registration type represents how we are going to de-/register efo consumer. */
+ public enum EFORegistrationType {
+
+ /**
+ * Delay the registration of efo consumer for taskmanager to execute. De-register the efo
+ * consumer for taskmanager to execute when task is shut down.
+ */
+ LAZY,
+ /**
+ * Register the efo consumer eagerly for jobmanager to execute. De-register the efo consumer
+ * the same way as lazy does.
+ */
+ EAGER,
+ /** Do not register efo consumer programmatically. Do not de-register either. */
+ NONE
+ }
+
+ /** The RecordPublisher type (EFO|POLLING). */
+ public static final String RECORD_PUBLISHER_TYPE = "flink.stream.recordpublisher";
Review Comment:
What are these constants / how are they used?
##########
flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/split/KinesisShardSplitSerializer.java:
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.source.split;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.connector.kinesis.source.exception.KinesisStreamsSourceException;
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+import org.apache.flink.core.io.VersionMismatchException;
+
+import software.amazon.awssdk.services.kinesis.model.ShardIteratorType;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
+
+/**
+ * Serializes and deserializes the {@link KinesisShardSplit}. This class needs to handle
+ * deserializing splits from older versions.
+ */
+@Internal
+public class KinesisShardSplitSerializer implements SimpleVersionedSerializer<KinesisShardSplit> {
+
+ private static final int CURRENT_VERSION = 0;
+
+ @Override
+ public int getVersion() {
+ return CURRENT_VERSION;
+ }
+
+ @Override
+ public byte[] serialize(KinesisShardSplit split) throws IOException {
+ try (ByteArrayOutputStream baos = new ByteArrayOutputStream();
+ ObjectOutputStream out = new ObjectOutputStream(baos)) {
+
+ out.writeUTF(split.getStreamArn());
+ out.writeUTF(split.getShardId());
+ out.writeUTF(split.getStartingPosition().getShardIteratorType().toString());
+ if (split.getStartingPosition().getStartingMarker() == null) {
+ out.writeBoolean(false);
+ } else {
+ out.writeBoolean(true);
+ out.writeObject(split.getStartingPosition().getStartingMarker());
Review Comment:
consider not using java serialization for this, unless you can guarantee that an `Instant` going through java serialization can be deserialized on a new JDK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org