You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2016/01/13 00:51:11 UTC
Review Request 42225: Add `--show-error` to curl when bootstrapping
thrift.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42225/
-----------------------------------------------------------
Review request for Aurora and John Sirois.
Repository: aurora
Description
-------
>From the curl documentation:
````
-S, --show-error
When used with -s it makes curl show an error message if it fails.
````
It's possible for curl to fail when grabbing the tarball or patch and this will
show users why it failed.
Diffs
-----
build-support/thrift/Makefile 8b1da2a01b9ecc1832d4e56bfaacb5b40cdbbab0
Diff: https://reviews.apache.org/r/42225/diff/
Testing
-------
Ran `make` in the `build-support/thrift` directory.
Thanks,
Zameer Manji
Re: Review Request 42225: Add `--show-error` to curl when
bootstrapping thrift.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42225/#review114112
-----------------------------------------------------------
Ship it!
Master (d542bd1) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 12, 2016, 11:51 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42225/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 11:51 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> From the curl documentation:
> ````
> -S, --show-error
>
> When used with -s it makes curl show an error message if it fails.
> ````
>
> It's possible for curl to fail when grabbing the tarball or patch and this will
> show users why it failed.
>
>
> Diffs
> -----
>
> build-support/thrift/Makefile 8b1da2a01b9ecc1832d4e56bfaacb5b40cdbbab0
>
> Diff: https://reviews.apache.org/r/42225/diff/
>
>
> Testing
> -------
>
> Ran `make` in the `build-support/thrift` directory.
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 42225: Add `--show-error` to curl when
bootstrapping thrift.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42225/#review114109
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Jan. 12, 2016, 3:51 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42225/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 3:51 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> From the curl documentation:
> ````
> -S, --show-error
>
> When used with -s it makes curl show an error message if it fails.
> ````
>
> It's possible for curl to fail when grabbing the tarball or patch and this will
> show users why it failed.
>
>
> Diffs
> -----
>
> build-support/thrift/Makefile 8b1da2a01b9ecc1832d4e56bfaacb5b40cdbbab0
>
> Diff: https://reviews.apache.org/r/42225/diff/
>
>
> Testing
> -------
>
> Ran `make` in the `build-support/thrift` directory.
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 42225: Add `--show-error` to curl when
bootstrapping thrift.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42225/#review114108
-----------------------------------------------------------
Ship it!
I almost always use -sS for this very reason - this makes sense to me!
build-support/thrift/Makefile (line 50)
<https://reviews.apache.org/r/42225/#comment174913>
>100 but I'm not sure how this goes in non-py|java files for aurora.
- John Sirois
On Jan. 12, 2016, 4:51 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42225/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 4:51 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> From the curl documentation:
> ````
> -S, --show-error
>
> When used with -s it makes curl show an error message if it fails.
> ````
>
> It's possible for curl to fail when grabbing the tarball or patch and this will
> show users why it failed.
>
>
> Diffs
> -----
>
> build-support/thrift/Makefile 8b1da2a01b9ecc1832d4e56bfaacb5b40cdbbab0
>
> Diff: https://reviews.apache.org/r/42225/diff/
>
>
> Testing
> -------
>
> Ran `make` in the `build-support/thrift` directory.
>
>
> Thanks,
>
> Zameer Manji
>
>