[GitHub] [ofbiz-framework] JacquesLeRoux commented on a change in pull request #305: Clean: Remove SVN references in build (OFBIZ-12267)

[GitBox <gi...@apache.org>]

JacquesLeRoux commented on a change in pull request #305:
URL: https://github.com/apache/ofbiz-framework/pull/305#discussion_r661330033



##########
File path: build.gradle
##########
@@ -16,7 +16,6 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import at.bxm.gradleplugins.svntools.tasks.SvnCheckout
 import org.apache.tools.ant.filters.ReplaceTokens
 import org.asciidoctor.gradle.AsciidoctorTask
 

Review comment:
       SvnCheckout and svntools should not be removed. They are still used by pullPluginSource and pullAllPluginsSource tasks which should also not be removed.

##########
File path: build.gradle
##########
@@ -959,11 +922,6 @@ task pullAllPluginsSource(group: ofbizPlugin,
     task deleteBeforePulling {
         doLast { delete "${pluginsDir}" }
     }
-    task pullPluginsFromSvn(type: SvnCheckout, dependsOn: deleteBeforePulling) {

Review comment:
       pullPluginsFromSvn should also not be removed. It uses a GH special feature.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org