[GitHub] [skywalking] hailin0 commented on a change in pull request #7463: Fix kafka-reporter-plugin shade package conflict

[GitBox <gi...@apache.org>]

hailin0 commented on a change in pull request #7463:
URL: https://github.com/apache/skywalking/pull/7463#discussion_r689093216



##########
File path: docs/en/setup/service-agent/java-agent/How-to-enable-kafka-reporter.md
##########
@@ -2,6 +2,8 @@
 
 The Kafka reporter plugin support report traces, JVM metrics, Instance Properties, and profiled snapshots to Kafka cluster, which is disabled in default. Move the jar of the plugin, `kafka-reporter-plugin-x.y.z.jar`, from `agent/optional-reporter-plugins` to `agent/plugins` for activating.
 
+If you configure to use `compression.type` such as `lz4`, `zstd`, `snappy`, etc., you also need to move the jar of the plugin, `lz4-java-x.y.z.jar` or `zstd-jni-x.y.z.jar` or `snappy-java.x.y.z.jar`, from `agent/optional-reporter-plugins` to `agent/plugins`.
+

Review comment:
       I tested was found `lz4` jar is not necessary, probably because the `wrapForOutput`、`wrapForInput` function is not called.
   
   https://github.com/apache/kafka/blob/2.4.1/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java#L388
   https://github.com/apache/kafka/blob/2.4.1/clients/src/main/java/org/apache/kafka/common/record/CompressionType.java#L99
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org