You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "David Latorre (JIRA)" <ji...@apache.org> on 2008/11/07 11:46:44 UTC
[jira] Created: (NET-242) Method createServerSocket of
FTPSSocketFactory will never be called and thus UseClientMode is incorrect
in a secured ftp transfer using active mode.
Method createServerSocket of FTPSSocketFactory will never be called and thus UseClientMode is incorrect in a secured ftp transfer using active mode.
-----------------------------------------------------------------------------------------------------------------------------------------------------
Key: NET-242
URL: https://issues.apache.org/jira/browse/NET-242
Project: Commons Net
Issue Type: Bug
Reporter: David Latorre
Priority: Minor
When the data channel is secured and we are using Active mode , we need to set UseClientMode to true in the FTP Client so even though the FtpServer is initiating the connection, he is the "server" in the SSL handshake.
In the current code , this is done in the method init() called by createServerSocket() in FTPSSocketFactory. But this method is never called as we create ServerSockets using a ServerSocketFactory.
The solution is to create a FTPSServerSocketFactory which takes the responsibility of creating ServerSockets.
Fix provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NET-242) Method createServerSocket of
FTPSSocketFactory will never be called and thus UseClientMode is incorrect
in a secured ftp transfer using active mode.
Posted by "David Latorre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Latorre updated NET-242:
------------------------------
Attachment: FTPSServerSocketFactory.java
FTPSSocketFactory.patch
FTPSClient.patch
FTPSServerSocketFactory is the new factory for ServerSockets.
We delete the createServerSocket() methods from FTPSSocketFactory. (Although this could be avoided for backwards compatibility).
FTPSClient patch will attach our ServerSocketFactory to the client in execProt().
> Method createServerSocket of FTPSSocketFactory will never be called and thus UseClientMode is incorrect in a secured ftp transfer using active mode.
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: NET-242
> URL: https://issues.apache.org/jira/browse/NET-242
> Project: Commons Net
> Issue Type: Bug
> Reporter: David Latorre
> Priority: Minor
> Attachments: FTPSClient.patch, FTPSServerSocketFactory.java, FTPSSocketFactory.patch
>
>
> When the data channel is secured and we are using Active mode , we need to set UseClientMode to true in the FTP Client so even though the FtpServer is initiating the connection, he is the "server" in the SSL handshake.
> In the current code , this is done in the method init() called by createServerSocket() in FTPSSocketFactory. But this method is never called as we create ServerSockets using a ServerSocketFactory.
> The solution is to create a FTPSServerSocketFactory which takes the responsibility of creating ServerSockets.
> Fix provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (NET-242) Method createServerSocket of
FTPSSocketFactory will never be called and thus UseClientMode is incorrect
in a secured ftp transfer using active mode.
Posted by "Rory Winston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rory Winston closed NET-242.
----------------------------
Resolution: Fixed
Fix Version/s: 2.1
Patches applied. Thanks David!
> Method createServerSocket of FTPSSocketFactory will never be called and thus UseClientMode is incorrect in a secured ftp transfer using active mode.
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: NET-242
> URL: https://issues.apache.org/jira/browse/NET-242
> Project: Commons Net
> Issue Type: Bug
> Reporter: David Latorre
> Priority: Minor
> Fix For: 2.1
>
> Attachments: FTPSClient.patch, FTPSServerSocketFactory.java, FTPSSocketFactory.patch
>
>
> When the data channel is secured and we are using Active mode , we need to set UseClientMode to true in the FTP Client so even though the FtpServer is initiating the connection, he is the "server" in the SSL handshake.
> In the current code , this is done in the method init() called by createServerSocket() in FTPSSocketFactory. But this method is never called as we create ServerSockets using a ServerSocketFactory.
> The solution is to create a FTPSServerSocketFactory which takes the responsibility of creating ServerSockets.
> Fix provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.