You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2020/10/29 08:52:45 UTC

[shardingsphere] branch master updated: refine synchronized block (#7958)

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 1fd45b3  refine synchronized block (#7958)
1fd45b3 is described below

commit 1fd45b306e5b9b073e7c895fac69ca616fc5e256
Author: Zhang Yonglun <zh...@apache.org>
AuthorDate: Thu Oct 29 16:52:15 2020 +0800

    refine synchronized block (#7958)
    
    * refine synchronized block
    
    * for comments
---
 .../apache/shardingsphere/sql/parser/api/SQLParserEngine.java    | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/api/SQLParserEngine.java b/shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/api/SQLParserEngine.java
index 12a1647..d73a0e3 100644
--- a/shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/api/SQLParserEngine.java
+++ b/shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/api/SQLParserEngine.java
@@ -68,13 +68,6 @@ public final class SQLParserEngine {
         if (ENGINES.containsKey(databaseType)) {
             return ENGINES.get(databaseType);
         }
-        synchronized (ENGINES) {
-            if (ENGINES.containsKey(databaseType)) {
-                return ENGINES.get(databaseType);
-            }
-            SQLParserExecutor result = new SQLParserExecutor(databaseType);
-            ENGINES.put(databaseType, result);
-            return result;
-        }
+        return ENGINES.computeIfAbsent(databaseType, key -> new SQLParserExecutor(databaseType));
     }
 }