You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jablko <gi...@git.apache.org> on 2017/02/09 16:49:00 UTC

[GitHub] trafficserver pull request #1433: Get the list of files from Autoconf vs. Gi...

GitHub user jablko opened a pull request:

    https://github.com/apache/trafficserver/pull/1433

    Get the list of files from Autoconf vs. Git

    This will work with source tarballs as well as checkouts.
    
    Fixes #1431

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jablko/trafficserver check

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1433.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1433
    
----
commit e40822afad1d9de22938d74717eb14211906b3f5
Author: Jack Bates <ja...@nottheoilrig.com>
Date:   2017-02-09T16:06:28Z

    Get the list of files from Autoconf vs. Git
    
    This will work with source tarballs as well as checkouts.
    
    Fixes #1431

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1433: Get the list of files from Autoconf vs. Git

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1433
  
    clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/58/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1433: Get the list of files from Autoconf vs. Git

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1433
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1387/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1433: Get the list of files from Autoconf vs. Git

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1433
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1412/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1433: Get the list of files from Autoconf vs. Git

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1433
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1391/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1433: Get the list of files from Autoconf vs. Git

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1433
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1518/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1433: Get the list of files from Autoconf vs. Git

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1433
  
    clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/62/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1433: Get the list of files from Autoconf vs. Gi...

Posted by jablko <gi...@git.apache.org>.
Github user jablko commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1433#discussion_r100367866
  
    --- Diff: configure.ac ---
    @@ -1937,6 +1939,9 @@ AC_CONFIG_FILES([
       tools/tsxs
     ])
     
    +AC_CONFIG_FILES([tools/check-unused-dependencies],
    +                [chmod +x tools/check-unused-dependencies])
    --- End diff --
    
    After this change, Git owns tools/check-unused-dependencies.in. But that reminds me: I should add tools/check-unused-dependencies to .gitignore ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1433: Get the list of files from Autoconf vs. Gi...

Posted by jablko <gi...@git.apache.org>.
Github user jablko closed the pull request at:

    https://github.com/apache/trafficserver/pull/1433


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1433: Get the list of files from Autoconf vs. Git

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1433
  
    clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/83/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1433: Get the list of files from Autoconf vs. Git

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1433
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1498/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1433: Get the list of files from Autoconf vs. Gi...

Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1433#discussion_r100366287
  
    --- Diff: configure.ac ---
    @@ -1937,6 +1939,9 @@ AC_CONFIG_FILES([
       tools/tsxs
     ])
     
    +AC_CONFIG_FILES([tools/check-unused-dependencies],
    +                [chmod +x tools/check-unused-dependencies])
    --- End diff --
    
    This looks odd, you are modifying the file attributes on a file owned by Git?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1433: Get the list of files from Autoconf vs. Git

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1433
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1494/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---