You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/23 10:15:44 UTC
[GitHub] [beam] mxm opened a new pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
mxm opened a new pull request #12065:
URL: https://github.com/apache/beam/pull/12065
There are currently no latency metrics in the load tests which makes it impossible to monitor latency regressions.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark
--- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-661938913
I've removed the GroupByKey from the ParDo test and instead added latency measurements to the dedicated GroupByKey load test. So both ParDo and GroupByKey measure latency now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-650125816
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-648048351
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on a change in pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on a change in pull request #12065:
URL: https://github.com/apache/beam/pull/12065#discussion_r458197231
##########
File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py
##########
@@ -147,10 +151,18 @@ def process(self, element, state=state_param):
CounterOperation(
self.number_of_counters, self.number_of_operations)))
+ if self.window:
+ pc = (
+ pc
+ | beam.WindowInto(beam.window.FixedWindows(1))
+ | beam.GroupByKey())
Review comment:
I've removed the GroupByKey here and added a latency measurement to the existing GroupByKey test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-648162367
Run Python Load Tests ParDo Flink Streaming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-648086665
Run Python Load Tests ParDo Flink Streaming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-650209128
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-652972556
Run PythonFormatter PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-648206600
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-648834656
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-650170436
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-648120617
Run Python Load Tests ParDo Flink Streaming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-648117962
Run Python Load Tests ParDo Flink Streaming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-652972679
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-650210143
Run Python Load Tests ParDo Flink Streaming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-650215379
Run PythonFormatter PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on a change in pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
kamilwu commented on a change in pull request #12065:
URL: https://github.com/apache/beam/pull/12065#discussion_r449141423
##########
File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py
##########
@@ -147,10 +151,18 @@ def process(self, element, state=state_param):
CounterOperation(
self.number_of_counters, self.number_of_operations)))
+ if self.window:
+ pc = (
+ pc
+ | beam.WindowInto(beam.window.FixedWindows(1))
+ | beam.GroupByKey())
Review comment:
I see. In this case, maybe it'd would worth to measure latency in GroupByKey Load Test: https://github.com/apache/beam/blob/master/sdks/python/apache_beam/testing/load_tests/group_by_key_test.py? GroupByKey step is already there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-648156395
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-650175781
Run PythonFormatter PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-650127686
Run Python Load Tests ParDo Flink Streaming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-650171573
Run Python Load Tests ParDo Flink Streaming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-650215296
Run Python2_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-648148297
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-648055510
Run Python Load Tests ParDo Flink Streaming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on a change in pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on a change in pull request #12065:
URL: https://github.com/apache/beam/pull/12065#discussion_r452361653
##########
File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py
##########
@@ -147,10 +151,18 @@ def process(self, element, state=state_param):
CounterOperation(
self.number_of_counters, self.number_of_operations)))
+ if self.window:
+ pc = (
+ pc
+ | beam.WindowInto(beam.window.FixedWindows(1))
+ | beam.GroupByKey())
Review comment:
Good point, I think we could move it there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-650266643
PythonFormatter / Python PreCommit are broken at the moment, but it's unrelated to the changes here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-648056258
Run Python2_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test
Posted by GitBox <gi...@apache.org>.
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-648096370
Run Python Load Tests ParDo Flink Streaming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org