You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/06/26 08:53:14 UTC
[PR] test(workflow-operator): add unit test coverage for Sklearn training NB & tree descriptors [texera]
aglinxinyuan opened a new pull request, #5954:
URL: https://github.com/apache/texera/pull/5954
### What changes were proposed in this PR?
Pin behavior of eight previously-untested Sklearn **training** operator descriptors in `common/workflow-operator`. No production-code changes.
| Spec | Source class |
| --- | --- |
| `SklearnTrainingBernoulliNaiveBayesOpDescSpec` | `SklearnTrainingBernoulliNaiveBayesOpDesc` |
| `SklearnTrainingComplementNaiveBayesOpDescSpec` | `SklearnTrainingComplementNaiveBayesOpDesc` |
| `SklearnTrainingGaussianNaiveBayesOpDescSpec` | `SklearnTrainingGaussianNaiveBayesOpDesc` |
| `SklearnTrainingMultinomialNaiveBayesOpDescSpec` | `SklearnTrainingMultinomialNaiveBayesOpDesc` |
| `SklearnTrainingDecisionTreeOpDescSpec` | `SklearnTrainingDecisionTreeOpDesc` |
| `SklearnTrainingExtraTreeOpDescSpec` | `SklearnTrainingExtraTreeOpDesc` |
| `SklearnTrainingExtraTreesOpDescSpec` | `SklearnTrainingExtraTreesOpDesc` |
| `SklearnTrainingRandomForestOpDescSpec` | `SklearnTrainingRandomForestOpDesc` |
**Behavior pinned** (shared `SklearnTrainingOpDesc` contract)
| Surface | Contract |
| --- | --- |
| `operatorInfo` | exact model name (`Training: <model>`) + `Sklearn <name> Operator` description; **Sklearn Training** group; single `training` input port; one blocking output |
| field defaults | `countVectorizer`/`tfidfTransformer` `false`; `target`/`text` `null` |
| `getOutputSchemas` | `model_name` (STRING) + `model` (BINARY) keyed by the declared output port |
| `generatePythonCode` | imports the matching sklearn estimator and builds the `make_pipeline(...).fit(X, Y)` training model |
| Round-trip | config fields preserved through the polymorphic `LogicalOp` base, with the correct `operatorType` discriminator |
### Any related issues, documentation, discussions?
Part of the ongoing `workflow-operator` unit-test coverage effort (the training-side counterpart to the Sklearn classifier coverage in #5925/#5939/#5940/#5941/#5945/#5946/#5951).
### How was this PR tested?
- `sbt "WorkflowOperator/testOnly org.apache.texera.amber.operator.sklearn.training.*"` — 40 tests, all green
- `sbt "WorkflowOperator/Test/scalafmtCheck"` and `sbt "WorkflowOperator/scalafixAll --check"` — clean
- CI to confirm
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): add unit test coverage for Sklearn training NB & tree descriptors [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5954:
URL: https://github.com/apache/texera/pull/5954#issuecomment-4808212339
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 3 worse · ⚪ 12 noise (<±5%) · 0 without baseline
> Compared against main `2ebfc28` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/28227794676)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 419 | 0.256 | 22,770/30,543/30,543 us | 🔴 +9.3% / 🔴 +105.2% |
| ⚪ | bs=100 sw=10 sl=64 | 856 | 0.522 | 114,067/142,266/142,266 us | ⚪ within ±5% / 🔴 +33.9% |
| ⚪ | bs=1000 sw=10 sl=64 | 958 | 0.585 | 1,046,739/1,073,850/1,073,850 us | ⚪ within ±5% / 🔴 +7.8% |
<details><summary>Baseline details</summary>
Latest main `2ebfc28` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 419 tuples/sec | 446 tuples/sec | 781.13 tuples/sec | -6.1% | -46.4% |
| bs=10 sw=10 sl=64 | MB/s | 0.256 MB/s | 0.272 MB/s | 0.477 MB/s | -5.9% | -46.3% |
| bs=10 sw=10 sl=64 | p50 | 22,770 us | 20,824 us | 12,542 us | +9.3% | +81.6% |
| bs=10 sw=10 sl=64 | p95 | 30,543 us | 30,674 us | 14,886 us | -0.4% | +105.2% |
| bs=10 sw=10 sl=64 | p99 | 30,543 us | 30,674 us | 17,580 us | -0.4% | +73.7% |
| bs=100 sw=10 sl=64 | throughput | 856 tuples/sec | 852 tuples/sec | 999.37 tuples/sec | +0.5% | -14.3% |
| bs=100 sw=10 sl=64 | MB/s | 0.522 MB/s | 0.52 MB/s | 0.61 MB/s | +0.4% | -14.4% |
| bs=100 sw=10 sl=64 | p50 | 114,067 us | 115,893 us | 99,687 us | -1.6% | +14.4% |
| bs=100 sw=10 sl=64 | p95 | 142,266 us | 143,085 us | 106,271 us | -0.6% | +33.9% |
| bs=100 sw=10 sl=64 | p99 | 142,266 us | 143,085 us | 115,445 us | -0.6% | +23.2% |
| bs=1000 sw=10 sl=64 | throughput | 958 tuples/sec | 975 tuples/sec | 1,036 tuples/sec | -1.7% | -7.5% |
| bs=1000 sw=10 sl=64 | MB/s | 0.585 MB/s | 0.595 MB/s | 0.632 MB/s | -1.7% | -7.5% |
| bs=1000 sw=10 sl=64 | p50 | 1,046,739 us | 1,017,296 us | 970,675 us | +2.9% | +7.8% |
| bs=1000 sw=10 sl=64 | p95 | 1,073,850 us | 1,068,932 us | 1,011,928 us | +0.5% | +6.1% |
| bs=1000 sw=10 sl=64 | p99 | 1,073,850 us | 1,068,932 us | 1,045,045 us | +0.5% | +2.8% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,476.85,200,128000,419,0.256,22770.33,30542.57,30542.57
1,100,10,64,20,2337.37,2000,1280000,856,0.522,114067.17,142265.90,142265.90
2,1000,10,64,20,20868.46,20000,12800000,958,0.585,1046739.23,1073850.44,1073850.44
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): add unit test coverage for Sklearn training NB & tree descriptors [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5954:
URL: https://github.com/apache/texera/pull/5954#issuecomment-4808072227
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): add unit test coverage for Sklearn training NB & tree descriptors [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #5954:
URL: https://github.com/apache/texera/pull/5954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): add unit test coverage for Sklearn training NB & tree descriptors [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5954:
URL: https://github.com/apache/texera/pull/5954#issuecomment-4808159000
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5954?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.91%. Comparing base ([`2ebfc28`](https://app.codecov.io/gh/apache/texera/commit/2ebfc2814e31acb8eebda78d369ebd74ea3e1410?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5f6e1f8`](https://app.codecov.io/gh/apache/texera/commit/5f6e1f85e605560575aaafceb4401b54dac15c60?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5954 +/- ##
=========================================
Coverage 54.91% 54.91%
Complexity 2956 2956
=========================================
Files 1117 1117
Lines 43133 43133
Branches 4648 4648
=========================================
Hits 23685 23685
Misses 18054 18054
Partials 1394 1394
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5954/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [2ebfc28](https://app.codecov.io/gh/apache/texera/commit/2ebfc2814e31acb8eebda78d369ebd74ea3e1410?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.36% <ø> (ø)` | | Carriedforward from [2ebfc28](https://app.codecov.io/gh/apache/texera/commit/2ebfc2814e31acb8eebda78d369ebd74ea3e1410?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.02% <ø> (ø)` | | Carriedforward from [2ebfc28](https://app.codecov.io/gh/apache/texera/commit/2ebfc2814e31acb8eebda78d369ebd74ea3e1410?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [2ebfc28](https://app.codecov.io/gh/apache/texera/commit/2ebfc2814e31acb8eebda78d369ebd74ea3e1410?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.56% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.02% <ø> (ø)` | | Carriedforward from [2ebfc28](https://app.codecov.io/gh/apache/texera/commit/2ebfc2814e31acb8eebda78d369ebd74ea3e1410?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.67% <ø> (ø)` | | Carriedforward from [2ebfc28](https://app.codecov.io/gh/apache/texera/commit/2ebfc2814e31acb8eebda78d369ebd74ea3e1410?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/5954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | Carriedforward from [2ebfc28](https://app.codecov.io/gh/apache/texera/commit/2ebfc2814e31acb8eebda78d369ebd74ea3e1410?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.20% <ø> (ø)` | | Carriedforward from [2ebfc28](https://app.codecov.io/gh/apache/texera/commit/2ebfc2814e31acb8eebda78d369ebd74ea3e1410?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.76% <ø> (ø)` | | Carriedforward from [2ebfc28](https://app.codecov.io/gh/apache/texera/commit/2ebfc2814e31acb8eebda78d369ebd74ea3e1410?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [2ebfc28](https://app.codecov.io/gh/apache/texera/commit/2ebfc2814e31acb8eebda78d369ebd74ea3e1410?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5954?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org