You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Grant Ingersoll <gs...@apache.org> on 2007/07/06 00:21:41 UTC

Author Tags

Solr just suggested (http://www.mail-archive.com/solr- 
dev@lucene.apache.org/msg04883.html) that they remove Author tags for  
a variety of good reasons.  What do people think of doing this in  
Lucene Java?

The ASF seems to discourage them, but ultimately leaves it up to the  
PMC (which, to my knowledge, hasn't made an official statement on).   
I don't think they belong in core, but could understand an argument  
for them being in contrib files since they are often the work of one  
or two people (not in all cases, though).  I also want to make sure  
we give proper credit to people (which I think we do via CHANGES.txt,  
but perhaps others would like some other credit system)

I don't feel particularly compelled to remove them (I think my search  
for @author turned up 500+ matches) at the moment, but I think we  
should discourage putting them in going forward and we can remove  
them as we come across them.  Of course, removing them all at once  
isn't that hard either.

Anyone have any preference?

-Grant


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Re: Author Tags

Posted by Doug Cutting <cu...@apache.org>.
DM Smith wrote:
> My question is whether contrib should have a separate policy?
> If the @author is removed from the file, should we make sure that there 
> is a CREDITS.txt for the contrib with the info in it.

Credit isn't file-by-file, it's commit-by-commit and recorded in both 
Jira and in CHANGES.txt, no matter whether core or contrib.

Doug

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Re: Author Tags

Posted by DM Smith <dm...@gmail.com>.
As a user of Lucene, I can go either way.
With an active developer community their need is lessened.

The greatest value I have found in them is being able to track down  
"duplicate" bugs. If I find a particular bug in one piece of code, I  
try to find other places where the same bug exists, on the assumption  
that people use cut and paste way too much and that each developer,  
for sanity's sake, uses a subset of a language and a set of personal  
coding patterns in writing code (same mistakes repeated).

My question is whether contrib should have a separate policy?
If the @author is removed from the file, should we make sure that  
there is a CREDITS.txt for the contrib with the info in it.

The reason I ask this is that some times I see posts here asking what  
the code intentions of the author were.

-- DM Smith

On Jul 5, 2007, at 6:21 PM, Grant Ingersoll wrote:

> Solr just suggested (http://www.mail-archive.com/solr- 
> dev@lucene.apache.org/msg04883.html) that they remove Author tags  
> for a variety of good reasons.  What do people think of doing this  
> in Lucene Java?
>
> The ASF seems to discourage them, but ultimately leaves it up to  
> the PMC (which, to my knowledge, hasn't made an official statement  
> on).  I don't think they belong in core, but could understand an  
> argument for them being in contrib files since they are often the  
> work of one or two people (not in all cases, though).  I also want  
> to make sure we give proper credit to people (which I think we do  
> via CHANGES.txt, but perhaps others would like some other credit  
> system)
>
> I don't feel particularly compelled to remove them (I think my  
> search for @author turned up 500+ matches) at the moment, but I  
> think we should discourage putting them in going forward and we can  
> remove them as we come across them.  Of course, removing them all  
> at once isn't that hard either.
>
> Anyone have any preference?
>
> -Grant
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Re: Author Tags

Posted by Michael McCandless <lu...@mikemccandless.com>.
+1

I think it makes sense to remove them at one fell swoop and also
discourage adding them going forward?

Mike

"Tom White" <to...@gmail.com> wrote:
> Hadoop recently removed all @author tags:
> https://issues.apache.org/jira/browse/HADOOP-1147.
> 
> Tom
> 
> On 05/07/07, Grant Ingersoll <gs...@apache.org> wrote:
> > Solr just suggested (http://www.mail-archive.com/solr-
> > dev@lucene.apache.org/msg04883.html) that they remove Author tags for
> > a variety of good reasons.  What do people think of doing this in
> > Lucene Java?
> >
> > The ASF seems to discourage them, but ultimately leaves it up to the
> > PMC (which, to my knowledge, hasn't made an official statement on).
> > I don't think they belong in core, but could understand an argument
> > for them being in contrib files since they are often the work of one
> > or two people (not in all cases, though).  I also want to make sure
> > we give proper credit to people (which I think we do via CHANGES.txt,
> > but perhaps others would like some other credit system)
> >
> > I don't feel particularly compelled to remove them (I think my search
> > for @author turned up 500+ matches) at the moment, but I think we
> > should discourage putting them in going forward and we can remove
> > them as we come across them.  Of course, removing them all at once
> > isn't that hard either.
> >
> > Anyone have any preference?
> >
> > -Grant
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: java-dev-help@lucene.apache.org
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Re: Author Tags

Posted by Tom White <to...@gmail.com>.
Hadoop recently removed all @author tags:
https://issues.apache.org/jira/browse/HADOOP-1147.

Tom

On 05/07/07, Grant Ingersoll <gs...@apache.org> wrote:
> Solr just suggested (http://www.mail-archive.com/solr-
> dev@lucene.apache.org/msg04883.html) that they remove Author tags for
> a variety of good reasons.  What do people think of doing this in
> Lucene Java?
>
> The ASF seems to discourage them, but ultimately leaves it up to the
> PMC (which, to my knowledge, hasn't made an official statement on).
> I don't think they belong in core, but could understand an argument
> for them being in contrib files since they are often the work of one
> or two people (not in all cases, though).  I also want to make sure
> we give proper credit to people (which I think we do via CHANGES.txt,
> but perhaps others would like some other credit system)
>
> I don't feel particularly compelled to remove them (I think my search
> for @author turned up 500+ matches) at the moment, but I think we
> should discourage putting them in going forward and we can remove
> them as we come across them.  Of course, removing them all at once
> isn't that hard either.
>
> Anyone have any preference?
>
> -Grant
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org