[jira] [Commented] (SPARK-18829) Printing to logger

["Marcelo Vanzin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742562#comment-15742562 ] 

Marcelo Vanzin commented on SPARK-18829:
----------------------------------------

I'm not so sure it's not a Spark issue. My understanding of the request is that he wants "explain" to either return a String or allow you to define where the output goes - right now Spark will only ever print it to stdout, so you can't really control it without messing with {{System.setOutputStream}} or whatever is the method name.

{{Dataset.show}} has {{Dataset.showString}} which can be used instead, but {{explain}} does not.

> Printing to logger
> ------------------
>
>                 Key: SPARK-18829
>                 URL: https://issues.apache.org/jira/browse/SPARK-18829
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>    Affects Versions: 1.6.2
>         Environment: ALL
>            Reporter: David Hodeffi
>            Priority: Trivial
>              Labels: easyfix, patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I would like to print dataframe.show or  df.explain(true)  into log file.
> right now the code print to standard output without a way to redirect it.
> It also cannot be configured on log4j.properties.
> My suggestion is to write to the logger and standard output.
> i.e 
> class DataFrame {......
> override def explain(extended: Boolean): Unit = {
>     val explain = ExplainCommand(queryExecution.logical, extended = extended)
>     sqlContext.executePlan(explain).executedPlan.executeCollect().foreach {
>       // scalastyle:off println
>       r => {
>                 println(r.getString(0))
>                 logger.debug(r.getString(0))
>       }
>      }
>       // scalastyle:on println
>     }
>   }
> def show(numRows: Int, truncate: Boolean): Unit = {
> val str =showString(numRows, truncate) 
> println(str)
> logger.debug(str)
> }
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org